Skip to content

numfmt: require equals for --header#13273

Merged
sylvestre merged 1 commit into
uutils:mainfrom
bachorp:numfmt_header
Jul 5, 2026
Merged

numfmt: require equals for --header#13273
sylvestre merged 1 commit into
uutils:mainfrom
bachorp:numfmt_header

Conversation

@bachorp

@bachorp bachorp commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #13272.

@github-actions

github-actions Bot commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Congrats! The gnu test tests/cut/bounded-memory is now passing!
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@codspeed-hq

codspeed-hq Bot commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 331 untouched benchmarks
⏩ 46 skipped benchmarks1

Comparing bachorp:numfmt_header (74ace85) with main (6b48ec7)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sylvestre

sylvestre commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

please add a test in tests/by-util/test_numfmt.rs to make sure we won't regress

@bachorp

bachorp commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

please add a test in tests/by-util/test_numfmt.rs to make sure we won't regress

Done.

@sylvestre sylvestre merged commit 70408d8 into uutils:main Jul 5, 2026
177 checks passed
@sylvestre

sylvestre commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

thanks

@bachorp bachorp deleted the numfmt_header branch July 5, 2026 10:56
sylvestre added a commit to sylvestre/coreutils-1 that referenced this pull request Jul 5, 2026
@sylvestre
tests: numfmt: check --header does not swallow a following operand
60f57f9 
* tests/numfmt/numfmt.pl (header-10): New test verifying that --header,
which only accepts an argument via '=', does not consume a following
operand as its value.
uutils/coreutils#13273
@sylvestre sylvestre mentioned this pull request Jul 5, 2026
Closed
hubot pushed a commit to coreutils/coreutils that referenced this pull request Jul 6, 2026
@sylvestre @pixelb
tests: numfmt: check --header does not swallow a following operand
68f15d9 
* tests/numfmt/numfmt.pl (header-10): New test verifying that --header,
which only accepts an argument via '=', does not consume a following
operand as its value.
uutils/coreutils#13273

Link: #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

numfmt: argument following --header interpreted incorrectly

2 participants

@bachorp @sylvestre