ut_output_buffer is now fully abstracted from caller#402
Closed
jgebal wants to merge 14 commits into
Closed
Conversation
… use reporter to get the output data. Introduced new abstract type: `ut_output_reporter_base`. Every reporter based on that type is supposed to use output buffer. So for every reporter of type `ut_output_reporter_base`, client can call functions: - get_lines - lines_to_dbms_output - get_lines_cursor Also, the reporters don't need to call parent reporter's method to finalize the reporting. New finalize event is added. There is no direct dependency between `ut_runner.run` and `ut_output_buffer` so we may now pass a reporter that doesn't report to output but saves data to table for example.
1 similar comment
2 similar comments
1 similar comment
2 similar comments
# Conflicts: # source/api/ut_runner.pkb
Pazus
reviewed
Jul 22, 2017
|
|
||
| end fire_event; | ||
|
|
||
| overriding member procedure fire_event(self in out nocopy ut_event_listener, a_event_name varchar2) is |
Member
There was a problem hiding this comment.
I propose to call it fire on event to be consistent with other similar procedures
Pazus
reviewed
Jul 22, 2017
| -- run hooks continued | ||
| member procedure after_calling_run (self in out nocopy ut_reporter_base, a_run in ut_run) | ||
| member procedure after_calling_run (self in out nocopy ut_reporter_base, a_run in ut_run), | ||
| not instantiable member procedure finalize(self in out nocopy ut_reporter_base) |
Member
There was a problem hiding this comment.
Could you add an explaining comment so the new reporter developer understand what he has to implement there if his reporter is not an output reporter
Member
Author
There was a problem hiding this comment.
@Pazus, or maybe it should have default (empty) implementation, like the rest of the methods?
1 similar comment
…s_object_model_fix
…s_object_model_fix # Conflicts: # source/api/ut_runner.pkb
2 similar comments
…ype. Created base type for output_buffers. Created header table for table output data. Updated `ut_output_reporter_base` to contain by default `ut_output_table_buffer` Updated tests for output buffers. Refreshed list of sources for RunAll script.
Member
Author
|
Closing this PR, will reopen from utPLSQL project feature branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #391
The caller can use reporter to get the output data.
Introduced new abstract type:
ut_output_reporter_base.Every reporter based on that type is supposed to use output buffer.
So for every reporter of type
ut_output_reporter_base, client can call functions:Also, the reporters don't need to call parent reporter's method to finalize the reporting.
New finalize event is added.
There is no direct dependency between
ut_runner.runandut_output_bufferso we may now pass a reporter that doesn't report to output but saves data to table for example.