Skip to content

271 implement usethis tool codespell#281

Merged
nathanjmcdougall merged 9 commits intomainfrom
271-implement-usethis-tool-codespell
Feb 7, 2025
Merged

271 implement usethis tool codespell#281
nathanjmcdougall merged 9 commits intomainfrom
271-implement-usethis-tool-codespell

Conversation

@nathanjmcdougall
Copy link
Collaborator

No description provided.

@nathanjmcdougall nathanjmcdougall linked an issue Feb 7, 2025 that may be closed by this pull request
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 7, 2025

CodSpeed Performance Report

Merging #281 will not alter performance

Comparing 271-implement-usethis-tool-codespell (5ea6fb5) with main (ba07928)

Summary

✅ 1 untouched benchmarks

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (01147b4) to head (5ea6fb5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   94.81%   95.01%   +0.19%     
==========================================
  Files          61       61              
  Lines        2702     2748      +46     
==========================================
+ Hits         2562     2611      +49     
+ Misses        140      137       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanjmcdougall
Copy link
Collaborator Author

In addition to addressing code coverage, we also should add this config by default;

ignore-regex = [
    "[A-Za-z0-9+/]{100,}" # Ignore long base64 strings
]

Because in notebook files, this gives a lot of false positives.

@nathanjmcdougall nathanjmcdougall merged commit 3dcd4c7 into main Feb 7, 2025
15 checks passed
@nathanjmcdougall nathanjmcdougall deleted the 271-implement-usethis-tool-codespell branch February 7, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement usethis tool codespell

2 participants