handle test failures with exceptions without message (via allure-framework#183)

letsrokk · baev · commit 8abfd9cd9846 · 2018-02-11T15:12:47.000+03:00
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java b/allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java
@@ -183,7 +183,7 @@ public static Optional<Status> getStatus(final Throwable throwable) {
     public static Optional<StatusDetails> getStatusDetails(final Throwable e) {
         return Optional.ofNullable(e)
                 .map(throwable -> new StatusDetails()
-                        .withMessage(throwable.getMessage())
+                        .withMessage(Optional.ofNullable(throwable.getMessage()).orElse(throwable.getClass().getName()))
                         .withTrace(getStackTraceAsString(throwable)));
     }
 
diff --git a/allure-junit4/src/test/java/io/qameta/allure/junit4/FeatureCombinationsTest.java b/allure-junit4/src/test/java/io/qameta/allure/junit4/FeatureCombinationsTest.java
@@ -4,6 +4,7 @@
 import io.qameta.allure.aspects.StepsAspects;
 import io.qameta.allure.junit4.samples.AssumptionFailedTest;
 import io.qameta.allure.junit4.samples.BrokenTest;
+import io.qameta.allure.junit4.samples.BrokenWithoutMessageTest;
 import io.qameta.allure.junit4.samples.FailedTest;
 import io.qameta.allure.junit4.samples.IgnoredClassTest;
 import io.qameta.allure.junit4.samples.IgnoredTests;
@@ -114,6 +115,23 @@ public void shouldProcessBrokenTest() throws Exception {
                 .hasSize(1)
                 .extracting(TestResult::getStatus)
                 .containsExactly(Status.BROKEN);
+        assertThat(testResults.get(0).getStatusDetails())
+                .hasFieldOrPropertyWithValue("message","Hello, everybody")
+                .hasFieldOrProperty("trace");
+    }
+
+    @Test
+    @DisplayName("Broken test without message")
+    public void shouldProcessBrokenWithoutMessageTest() throws Exception {
+        core.run(Request.aClass(BrokenWithoutMessageTest.class));
+        List<TestResult> testResults = results.getTestResults();
+        assertThat(testResults)
+                .hasSize(1)
+                .extracting(TestResult::getStatus)
+                .containsExactly(Status.BROKEN);
+        assertThat(testResults.get(0).getStatusDetails())
+                .hasFieldOrPropertyWithValue("message","java.lang.RuntimeException")
+                .hasFieldOrProperty("trace");
     }
 
     @Test
diff --git a/allure-junit4/src/test/java/io/qameta/allure/junit4/samples/BrokenWithoutMessageTest.java b/allure-junit4/src/test/java/io/qameta/allure/junit4/samples/BrokenWithoutMessageTest.java
@@ -0,0 +1,14 @@
+package io.qameta.allure.junit4.samples;
+
+import org.junit.Test;
+
+/**
+ * @author charlie (Dmitry Baev).
+ */
+public class BrokenWithoutMessageTest {
+
+    @Test
+    public void brokenWithoutMessageTest() throws Exception {
+        throw new RuntimeException();
+    }
+}
diff --git a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java
@@ -174,6 +174,33 @@ public void brokenTest() {
                 .hasFieldOrPropertyWithValue("status", Status.BROKEN)
                 .hasFieldOrPropertyWithValue("stage", Stage.FINISHED)
                 .hasFieldOrPropertyWithValue("name", testName);
+        assertThat(testResult.get(0).getStatusDetails()).as("Test Status Details")
+                .hasFieldOrPropertyWithValue("message","Exception")
+                .hasFieldOrProperty("trace");
+        assertThat(testResult)
+                .flatExtracting(TestResult::getSteps)
+                .hasSize(2)
+                .flatExtracting(StepResult::getStatus)
+                .contains(Status.PASSED, Status.BROKEN);
+    }
+
+    @Feature("Failed tests")
+    @Story("Broken")
+    @Test(description = "Broken testng - Exception without message")
+    public void brokenTestWithOutMessage() {
+        String testName = "brokenTestWithoutMessage";
+        runTestNgSuites("suites/brokenWithoutMessage.xml");
+        List<TestResult> testResult = results.getTestResults();
+
+        assertThat(testResult).as("Test case result has not been written").hasSize(1);
+        assertThat(testResult.get(0)).as("Unexpected broken testng property")
+                .hasFieldOrPropertyWithValue("status", Status.BROKEN)
+                .hasFieldOrPropertyWithValue("stage", Stage.FINISHED)
+                .hasFieldOrPropertyWithValue("name", testName);
+        assertThat(testResult.get(0).getStatusDetails()).as("Test Status Details")
+                .hasFieldOrPropertyWithValue("message","java.lang.RuntimeException")
+                .hasFieldOrProperty("trace");
+
         assertThat(testResult)
                 .flatExtracting(TestResult::getSteps)
                 .hasSize(2)
diff --git a/allure-testng/src/test/java/io/qameta/allure/testng/samples/TestsWithSteps.java b/allure-testng/src/test/java/io/qameta/allure/testng/samples/TestsWithSteps.java
@@ -48,8 +48,19 @@ public void brokenTest() {
         broken();
     }
 
+    @Test
+    public void brokenTestWithoutMessage() {
+        stepOne();
+        brokenWithoutMessage();
+    }
+
     @Step
     private void broken() {
         throw new RuntimeException("Exception");
     }
+
+    @Step
+    private void brokenWithoutMessage() {
+        throw new RuntimeException();
+    }
 }
diff --git a/allure-testng/src/test/resources/suites/brokenWithoutMessage.xml b/allure-testng/src/test/resources/suites/brokenWithoutMessage.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
+
+<suite name="Test suite with broken tests">
+    <test name="Test Exceptions Without Message">
+        <classes>
+            <class name="io.qameta.allure.testng.samples.TestsWithSteps">
+                <methods>
+                    <include name="brokenTestWithoutMessage"/>
+                </methods>
+            </class>
+        </classes>
+    </test>
+</suite>

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ public static Optional<Status> getStatus(final Throwable throwable) {`
`183`	`183`	`public static Optional<StatusDetails> getStatusDetails(final Throwable e) {`
`184`	`184`	`return Optional.ofNullable(e)`
`185`	`185`	`.map(throwable -> new StatusDetails()`
`186`		`- .withMessage(throwable.getMessage())`
	`186`	`+ .withMessage(Optional.ofNullable(throwable.getMessage()).orElse(throwable.getClass().getName()))`
`187`	`187`	`.withTrace(getStackTraceAsString(throwable)));`
`188`	`188`	`}`
`189`	`189`
Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,19 @@ public void brokenTest() {`
`48`	`48`	`broken();`
`49`	`49`	`}`
`50`	`50`
	`51`	`+ @Test`
	`52`	`+ public void brokenTestWithoutMessage() {`
	`53`	`+ stepOne();`
	`54`	`+ brokenWithoutMessage();`
	`55`	`+ }`
	`56`	`+`
`51`	`57`	`@Step`
`52`	`58`	`private void broken() {`
`53`	`59`	`throw new RuntimeException("Exception");`
`54`	`60`	`}`
	`61`	`+`
	`62`	`+ @Step`
	`63`	`+ private void brokenWithoutMessage() {`
	`64`	`+ throw new RuntimeException();`
	`65`	`+ }`
`55`	`66`	`}`