r8 | charles.nicholson | 2010-03-16 21:27:33 -0500 (Tue, 16 Mar 2010) | 1 line

pjohnmeyer · pjohnmeyer · commit 3a40aa80a1c8 · 2013-01-09T23:43:07.000-06:00
fixed bug where tests weren't correctly executing while testing the TestRunner (accessing the Details and Results singletons was redirecting failures to bogus RecordingReporters, instead of the real UT++ test engine).  Hoisted assert failure reporting into ReportAssert, in preparation for setjmp/longjmp assert handling in the absence of exceptions.  Slight renamings and cosmetic fixups
diff --git a/src/AssertException.cpp b/src/AssertException.cpp
@@ -2,38 +2,16 @@
 
 #ifdef UNITTEST_USE_EXCEPTIONS
 
-#include <cstring>
-
 namespace UnitTest {
 
-AssertException::AssertException(char const* description, char const* filename, int lineNumber)
-    : m_lineNumber(lineNumber)
+AssertException::AssertException()
 {
-	using namespace std;
-
-    strcpy(m_description, description);
-    strcpy(m_filename, filename);
 }
 
 AssertException::~AssertException()
 {
 }
 
-char const* AssertException::what() const
-{
-    return m_description;
-}
-
-char const* AssertException::Filename() const
-{
-    return m_filename;
-}
-
-int AssertException::LineNumber() const
-{
-    return m_lineNumber;
-}
-
 }
 
 #endif
diff --git a/src/AssertException.h b/src/AssertException.h
@@ -12,18 +12,8 @@ namespace UnitTest {
 class AssertException : public std::exception
 {
 public:
-    AssertException(char const* description, char const* filename, int lineNumber);
+    AssertException();
     virtual ~AssertException();
-
-    virtual char const* what() const;
-
-    char const* Filename() const;
-    int LineNumber() const;
-
-private:
-    char m_description[512];
-    char m_filename[256];
-    int m_lineNumber;
 };
 
 }
diff --git a/src/CheckMacros.h b/src/CheckMacros.h
@@ -130,10 +130,15 @@
         if (!caught_) \
 	        UnitTest::CurrentTest::Results()->OnTestFailure(UnitTest::TestDetails(*UnitTest::CurrentTest::Details(), __LINE__), "Expected exception: \"" #ExpectedExceptionType "\" not thrown"); \
     } while(0)
-#endif
 
 
 #define CHECK_ASSERT(expression) \
-    CHECK_THROW(expression, UnitTest::AssertException);
+	do \
+	{ \
+		UnitTest::ExpectAssert(true); \
+		CHECK_THROW(expression, UnitTest::AssertException); \
+		UnitTest::ExpectAssert(false); \
+	} while(0)
 
 #endif
+#endif
diff --git a/src/ExecuteTest.h b/src/ExecuteTest.h
@@ -14,9 +14,10 @@
 namespace UnitTest {
 
 template< typename T >
-void ExecuteTest(T& testObject, TestDetails const& details)
+void ExecuteTest(T& testObject, TestDetails const& details, bool isMockTest)
 {
-	CurrentTest::Details() = &details;
+	if (isMockTest == false)
+		CurrentTest::Details() = &details;
 
 #ifndef UNITTEST_POSIX
 	UT_TRY
@@ -33,8 +34,7 @@ void ExecuteTest(T& testObject, TestDetails const& details)
 
 	UT_CATCH(AssertException, e,
 	{
-		CurrentTest::Results()->OnTestFailure(
-			TestDetails(details.testName, details.suiteName, e.Filename(), e.LineNumber()), e.what());
+		(void)e;
 	})
 	UT_CATCH(std::exception, e,
 	{
@@ -44,7 +44,7 @@ void ExecuteTest(T& testObject, TestDetails const& details)
 	})
 	UT_CATCH_ALL
 	({
-		CurrentTest::Results()->OnTestFailure(details, "Unhandled exception: Crash!");
+		CurrentTest::Results()->OnTestFailure(details, "Unhandled exception: test crashed");
 	})
 }
 
diff --git a/src/ReportAssert.cpp b/src/ReportAssert.cpp
@@ -1,17 +1,52 @@
 #include "ReportAssert.h"
 #include "AssertException.h"
+#include "CurrentTest.h"
+#include "TestResults.h"
+#include "TestDetails.h"
 
 namespace UnitTest {
 
+namespace
+{
+	bool& AssertExpectedFlag()
+	{
+		static bool s_assertExpected = false;
+		return s_assertExpected;
+	}
+}
+
 void ReportAssert(char const* description, char const* filename, int lineNumber)
 {
-	(void)description;
-	(void)filename;
-	(void)lineNumber;
+	ReportAssertEx(CurrentTest::Results(), CurrentTest::Details(), description, filename, lineNumber);
+}
+
+void ReportAssertEx(TestResults* testResults,
+					const TestDetails* testDetails,
+					char const* description, 
+					char const* filename, 
+					int lineNumber)
+{
+	if (AssertExpectedFlag() == false)
+	{
+		TestDetails assertDetails(testDetails->testName, testDetails->suiteName, filename, lineNumber);
+		testResults->OnTestFailure(assertDetails, description);
+	}
+
+	ExpectAssert(false);
 
 #ifdef UNITTEST_USE_EXCEPTIONS
-    throw AssertException(description, filename, lineNumber);
+	throw AssertException();
 #endif
 }
 
+void ExpectAssert(bool expected)
+{
+	AssertExpectedFlag() = expected;
+}
+
+bool AssertExpected()
+{
+	return AssertExpectedFlag();
+}
+
 }
diff --git a/src/ReportAssert.h b/src/ReportAssert.h
@@ -3,8 +3,20 @@
 
 namespace UnitTest {
 
+class TestResults;
+class TestDetails;
+
 void ReportAssert(char const* description, char const* filename, int lineNumber);
-    
+
+void ReportAssertEx(TestResults* testResults, 
+					const TestDetails* testDetails,
+					char const* description, 
+					char const* filename, 
+					int lineNumber);
+
+void ExpectAssert(bool expected);
+bool AssertExpected();
+
 }
 
 #endif
diff --git a/src/Test.cpp b/src/Test.cpp
@@ -20,8 +20,9 @@ TestList& Test::GetTestList()
 
 Test::Test(char const* testName, char const* suiteName, char const* filename, int lineNumber)
     : m_details(testName, suiteName, filename, lineNumber)
-    , next(0)
+    , m_nextTest(0)
     , m_timeConstraintExempt(false)
+	, m_isMockTest(false)
 {
 }
 
@@ -31,7 +32,7 @@ Test::~Test()
 
 void Test::Run()
 {
-	ExecuteTest(*this, m_details);
+	ExecuteTest(*this, m_details, m_isMockTest);
 }
 
 void Test::RunImpl() const
diff --git a/src/Test.h b/src/Test.h
@@ -16,8 +16,9 @@ class Test
     void Run();
 
     TestDetails const m_details;
-    Test* next;
+    Test* m_nextTest;
     mutable bool m_timeConstraintExempt;
+	mutable bool m_isMockTest;
 
     static TestList& GetTestList();
 
diff --git a/src/TestList.cpp b/src/TestList.cpp
@@ -21,7 +21,7 @@ void TestList::Add(Test* test)
     }
     else
     {
-        m_tail->next = test;
+        m_tail->m_nextTest = test;
         m_tail = test;
     }
 }
diff --git a/src/TestMacros.h b/src/TestMacros.h
@@ -83,11 +83,11 @@
 		({ \
 			Fixture##Name##Helper fixtureHelper(m_details);							 \
 			ctorOk = true;															 \
-			UnitTest::ExecuteTest(fixtureHelper, m_details);						 \
+			UnitTest::ExecuteTest(fixtureHelper, m_details, false);					 \
 		}) \
 		UT_CATCH (UnitTest::AssertException, e, \
 		{ \
-			UnitTest::CurrentTest::Results()->OnTestFailure(UnitTest::TestDetails(m_details.testName, m_details.suiteName, e.Filename(), e.LineNumber()), e.what()); \
+			(void)e;	\
 		}) \
 		UT_CATCH (std::exception, e, \
 		{ \
diff --git a/src/TestRunner.cpp b/src/TestRunner.cpp
@@ -32,6 +32,11 @@ TestRunner::~TestRunner()
 	delete m_timer;
 }
 
+TestResults* TestRunner::GetTestResults()
+{
+	return m_result;
+}
+
 int TestRunner::Finish() const
 {
     float const secondsElapsed = static_cast<float>(m_timer->GetTimeInMs() / 1000.0);
@@ -51,7 +56,8 @@ bool TestRunner::IsTestInSuite(const Test* const curTest, char const* suiteName)
 
 void TestRunner::RunTest(TestResults* const result, Test* const curTest, int const maxTestTimeInMs) const
 {
-	CurrentTest::Results() = result;
+	if (curTest->m_isMockTest == false)
+		CurrentTest::Results() = result;
 
 	Timer testTimer;
 	testTimer.Start();
@@ -70,7 +76,7 @@ void TestRunner::RunTest(TestResults* const result, Test* const curTest, int con
 	    result->OnTestFailure(curTest->m_details, stream.GetText());
 	}
 
-	result->OnTestFinish(curTest->m_details, static_cast<float>(testTimeInMs/1000.0));
+	result->OnTestFinish(curTest->m_details, static_cast< float >(testTimeInMs / 1000.0));
 }
 
 }
diff --git a/src/TestRunner.h b/src/TestRunner.h
@@ -27,7 +27,7 @@ class TestRunner
 	explicit TestRunner(TestReporter& reporter);
 	~TestRunner();
 
-	template <class Predicate>
+	template< class Predicate >
 	int RunTestsIf(TestList const& list, char const* suiteName, 
 				   const Predicate& predicate, int maxTestTimeInMs) const
 	{
@@ -38,12 +38,14 @@ class TestRunner
 		    if (IsTestInSuite(curTest, suiteName) && predicate(curTest))
 				RunTest(m_result, curTest, maxTestTimeInMs);
 
-			curTest = curTest->next;
+			curTest = curTest->m_nextTest;
 	    }
 
 	    return Finish();
 	}	
 
+	TestResults* GetTestResults();
+
 private:
 	TestReporter* m_reporter;
 	TestResults* m_result;
diff --git a/src/tests/TestAssertHandler.cpp b/src/tests/TestAssertHandler.cpp
diff --git a/src/tests/TestTestList.cpp b/src/tests/TestTestList.cpp
diff --git a/src/tests/TestTestMacros.cpp b/src/tests/TestTestMacros.cpp
diff --git a/src/tests/TestTestRunner.cpp b/src/tests/TestTestRunner.cpp

Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,9 @@ TestList& Test::GetTestList()`
`20`	`20`
`21`	`21`	`Test::Test(char const* testName, char const* suiteName, char const* filename, int lineNumber)`
`22`	`22`	`: m_details(testName, suiteName, filename, lineNumber)`
`23`		`- , next(0)`
	`23`	`+ , m_nextTest(0)`
`24`	`24`	`, m_timeConstraintExempt(false)`
	`25`	`+ , m_isMockTest(false)`
`25`	`26`	`{`
`26`	`27`	`}`
`27`	`28`
`@@ -31,7 +32,7 @@ Test::~Test()`
`31`	`32`
`32`	`33`	`void Test::Run()`
`33`	`34`	`{`
`34`		`- ExecuteTest(*this, m_details);`
	`35`	`+ ExecuteTest(*this, m_details, m_isMockTest);`
`35`	`36`	`}`
`36`	`37`
`37`	`38`	`void Test::RunImpl() const`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ void TestList::Add(Test* test)`
`21`	`21`	`}`
`22`	`22`	`else`
`23`	`23`	`{`
`24`		`- m_tail->next = test;`
	`24`	`+ m_tail->m_nextTest = test;`
`25`	`25`	`m_tail = test;`
`26`	`26`	`}`
`27`	`27`	`}`