fix: update ganache version to fix arbitrum test#311
Merged
ErikBjare merged 1 commit intouniswap-python:masterfrom Jan 12, 2023
Merged
fix: update ganache version to fix arbitrum test#311ErikBjare merged 1 commit intouniswap-python:masterfrom
ErikBjare merged 1 commit intouniswap-python:masterfrom
Conversation
Contributor
Author
|
Tests are failing due to failure to upload coverage report to Codecov (potentially missing the codecov repo upload token) |
Member
|
Nice, thanks! Not sure why codecov suddenly fails, I guess it's a foreign-user PR issue? Merging anyway :) |
Contributor
Author
|
thank you! :) |
Contributor
Author
|
@ErikBjare Unfortunately it seems like the tests are still failing |
Member
|
Seems like the tests are failing due to codecov/codecov-action#557 (comment) I've set |
Contributor
Author
|
perfect! works now! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arbitrum tests have been failing due to a
Invalid transaction type: 106error. More info.This is fixed in the newer version of ganache.