test: add test for ValueError in make_trade_output#301
Merged
ErikBjare merged 1 commit intouniswap-python:masterfrom Dec 23, 2022
Merged
test: add test for ValueError in make_trade_output#301ErikBjare merged 1 commit intouniswap-python:masterfrom
ErikBjare merged 1 commit intouniswap-python:masterfrom
Conversation
Codecov ReportBase: 84.06% // Head: 84.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 84.06% 84.16% +0.09%
==========================================
Files 10 10
Lines 1042 1042
==========================================
+ Hits 876 877 +1
+ Misses 166 165 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ErikBjare
changed the title
Member
|
Thanks @brndtoast! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will like to work on issue #265
Tested locally and test runs well. I also pushed a PR on my own fork to test.
In this PR I added a simple test to slightly improve code coverage and also to test the workflow