Enable caching to reduce RPC calls#276
Conversation
enable caching, will reduce RPC calls for method chainID
|
The Perhaps look into some of the more sophisticated caching methods? Or we might just want to inform users how to do this themselves in the docs by constructing a custom web3 with a caching layer of choice. Edit: It seems you can provide a |
|
good call @ErikBjare , adding changes |
- custom eth caching middleware creation - custom SIMPLE_CACHE_RPC_WHITELIST - flag to enable/disable caching for class Uniswap
|
added changes, looking for any commentary |
ErikBjare
left a comment
ErikBjare
left a comment
There was a problem hiding this comment.
Looks good! Going to let CI run now and will merge if it works :)
Codecov ReportBase: 84.56% // Head: 84.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 84.56% 84.13% -0.43%
==========================================
Files 10 10
Lines 1030 1040 +10
==========================================
+ Hits 871 875 +4
- Misses 159 165 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thanks for this @PawlowskiAdrian :) |
2 participants
enable caching, will reduce RPC calls for method chainID