Skip to content

fix: typing issues in uniswap.py #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Dec 21, 2021
Merged

fix: typing issues in uniswap.py #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions uniswap/uniswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import time
import logging
import functools
from typing import List, Any, Optional, Union, Tuple, Dict
from typing import List, Any, Optional, Union, Tuple, Dict, Iterable

from web3 import Web3
from web3.eth import Contract
Expand Down Expand Up @@ -1229,7 +1229,7 @@ def get_raw_price(
token_out = self.get_weth_address()

if self.version == 2:
params = [
params: Iterable[Union[ChecksumAddress,Optional[int]]] = [
self.w3.toChecksumAddress(token_in),
self.w3.toChecksumAddress(token_out),
]
Expand Down Expand Up @@ -1310,7 +1310,7 @@ def estimate_price_impact(
return 1

if price_small == 0:
# Occures when `token_out` amount in the pool equals 0
# Occurs when `token_out` amount in the pool equals 0
return 1
try:
cost_amount = self.get_price_input(
Expand All @@ -1324,7 +1324,7 @@ def estimate_price_impact(
cost_amount / (amount_in / (10 ** self.get_token(token_in).decimals))
) / 10 ** self.get_token(token_out).decimals

return (price_small - price_amount) / price_small
return float((price_small - price_amount) / price_small)

# ------ Exchange ------------------------------------------------------------------
@supports([1, 2])
Expand Down