Skip to content

chore: bump all non-breaking dev deps#78

Merged
JounQin merged 2 commits intomainfrom
chore/bump
Apr 5, 2025
Merged

chore: bump all non-breaking dev deps#78
JounQin merged 2 commits intomainfrom
chore/bump

Conversation

@JounQin
Copy link
Member

@JounQin JounQin commented Apr 4, 2025

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

As title

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Apr 4, 2025
@JounQin JounQin requested review from Copilot and wooorm and removed request for Copilot April 4, 2025 11:39
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

readme.md:614

  • Verify that changing the code block language from 'txt' to 'console' correctly renders the expected output in all environments; if the output differs from expectations, consider using a different language identifier.
```console

readme.md:1658

  • Confirm that the removal of these duplicate link references does not break any documentation links that may be used elsewhere.
-[node-readable-stream]: https://nodejs.org/api/stream.html#readable-streams

remcohaszing
remcohaszing requested changes Apr 4, 2025
View reviewed changes
remcohaszing
remcohaszing requested changes Apr 4, 2025
View reviewed changes
@JounQin JounQin changed the title chore: bump all (dev) deps chore: bump all non-breaking (dev) deps Apr 4, 2025
@wooorm
Copy link
Member

wooorm commented Apr 4, 2025

Please split in different PRs. Dev-deps are fine in this PR. Actual deps are breaking changes.

Please use text for text, not console, which isn’t text

@JounQin
Copy link
Member Author

JounQin commented Apr 4, 2025 •
edited
Loading

Please split in different PRs. Dev-deps are fine in this PR. Actual deps are breaking changes.

Now, only dev deps change.

Please use text for text, not console, which isn’t text

Your preset refuses that.

I misunderstood txt vs text, I've changed those parts, although I still think console is just for those cases personally.

@JounQin JounQin changed the title chore: bump all non-breaking (dev) deps chore: bump all non-breaking dev deps Apr 4, 2025
@JounQin
Copy link
Member Author

JounQin commented Apr 4, 2025 •
edited
Loading

@wooorm And also, as I mentioned, console is for ShellSession, I believe the text blocks are ShellSession exactly?

JounQin
JounQin commented Apr 4, 2025
View reviewed changes
@JounQin JounQin merged commit 9a92f16 into main Apr 5, 2025
8 checks passed
@JounQin JounQin deleted the chore/bump branch April 5, 2025 04:38
@github-actions

This comment has been minimized.

Sign in to view
@wooorm
Copy link
Member

wooorm commented Apr 7, 2025 •
edited
Loading

console is for ShellSession, I believe the text blocks are ShellSession exactly?

Many are txt -> txt. That is intention.
Perhaps one is a shell session, but such changes can go in different PRs.

When you merge PRs, please follow the existing commit style:
https://github.com/unifiedjs/unified-engine/commits/main/. Try and keep this consistent. Thank you!

Also, please apply labels. The bot helps you with this. In this case, I will add phase/solved for you.

wooorm pushed a commit that referenced this pull request Apr 7, 2025
@JounQin @wooorm
Update dev-dependencies
10bf51d 
Closes GH-78.

Reviewed-by: Remco Haszing <[email protected]>
Reviewed-by: Christian Murphy <[email protected]>
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 7, 2025
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Apr 7, 2025
@JounQin
Copy link
Member Author

JounQin commented Apr 7, 2025

Try and keep this consistent. Thank you!

@wooorm Could there be a tool for checking this on pre-commit hook?

(I'll wait for you to merge PRs after then

@wooorm
Copy link
Member

wooorm commented Apr 7, 2025

Maybe, but, as you know, I don’t think there needs to be a tool for everything 😉

I’d much rather teach you the style, that you can then merge PRs yourself! I would like for you to merge PRs!

Take a look at the commits there (or in other repos, such as mdx-js/mdx).
It’s basically:

  • Change/Add/Remove/Update/Refactor
  • and then some subject

The most common commits are Update dev-dependencies and Refactor code-style.
That signals that nothing actual changed.
It doesn’t go in the changelog.

@JounQin
Copy link
Member Author

JounQin commented Apr 7, 2025

I’d much rather teach you the style, that you can then merge PRs yourself! I would like for you to merge PRs!

Thanks! I'll learn to do that correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@remcohaszing remcohaszing remcohaszing approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@wooorm wooorm Awaiting requested review from wooorm

Assignees

No one assigned

Labels

💪 phase/solved Post is done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JounQin @wooorm @remcohaszing @ChristianMurphy