Accept non mutable array of plugins in the use function#267
Closed
pcorpet wants to merge 1 commit intounifiedjs:mainfrom
Closed
Accept non mutable array of plugins in the use function#267pcorpet wants to merge 1 commit intounifiedjs:mainfrom
pcorpet wants to merge 1 commit intounifiedjs:mainfrom
Conversation
This change is compatible with previous code, it makes it more obvious that the library does not modify the array of plugins and only iterates over the array. Fixes unifiedjs#266
This comment has been minimized.
This comment has been minimized.
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 1364 1380 +16
=========================================
+ Hits 1364 1380 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
🤞 phase/open
Member
|
closing, see #266 (comment) |
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
👎 phase/no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is compatible with previous code, it makes it more obvious that the library does not modify the array of plugins and only iterates over the array.
Fixes #266
Initial checklist
Description of changes
Change the type of the first parameter of
useto accept not only arrays but also readonly arrays (immutable). As the library does not modify it, we can accept this wider type.