Skip to content

refactor: improve console setup logic to prioritize valid executables#33

Merged
umuttopalak merged 1 commit intomasterfrom
fix/console-type
Jan 16, 2025
Merged

refactor: improve console setup logic to prioritize valid executables#33
umuttopalak merged 1 commit intomasterfrom
fix/console-type

Conversation

@umuttopalak
Copy link
Owner

@umuttopalak umuttopalak commented Jan 16, 2025

Closes #29

  • Updated the setupConsole function across src/index.ts, lib/index.js, and dist/index.js to enhance the logic for selecting a console executable.
  • Replaced the previous method of popping the last console from the list with a search for valid executables (bash or sh).
  • Ensured that a new console is created only if no valid executables are found, improving the robustness of the console setup process.

- Updated the `setupConsole` function across `src/index.ts`, `lib/index.js`, and `dist/index.js` to enhance the logic for selecting a console executable.
- Replaced the previous method of popping the last console from the list with a search for valid executables (`bash` or `sh`).
- Ensured that a new console is created only if no valid executables are found, improving the robustness of the console setup process.
@umuttopalak umuttopalak merged commit d854c58 into master Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console Type

1 participant