refactor: improve console setup logic to prioritize valid executables#33
Merged
umuttopalak merged 1 commit intomasterfrom Jan 16, 2025
Merged
refactor: improve console setup logic to prioritize valid executables#33umuttopalak merged 1 commit intomasterfrom
umuttopalak merged 1 commit intomasterfrom
Conversation
- Updated the `setupConsole` function across `src/index.ts`, `lib/index.js`, and `dist/index.js` to enhance the logic for selecting a console executable. - Replaced the previous method of popping the last console from the list with a search for valid executables (`bash` or `sh`). - Ensured that a new console is created only if no valid executables are found, improving the robustness of the console setup process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
setupConsolefunction acrosssrc/index.ts,lib/index.js, anddist/index.jsto enhance the logic for selecting a console executable.bashorsh).