Open
Conversation
This allows building with Go 1.25+ Signed-off-by: Paul Meyer <[email protected]>
Contributor
|
It does seem to break 1.24.x CI though. Would it make sense to integrate this change into #3508 potentially? |
Author
Go 1.24 is EOL and shouldn't be used.
Sure feel free to close this if there is another solution. I opened this as I needed to apply the patch downstream in nixpkgs to fix the package on Go 1.24 removal. |
Member
|
Thanks for your PR. We've found it useful over the years to support 3 or so versions of the toolchain, as not everyone is always up to date. I'll try to see what went wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows building with Go 1.25+