Skip to content

ci: separate the windows CI tests into build and test#6

Open
tomato wants to merge 1 commit into
masterfrom
windows-executor-no-cache
Open

ci: separate the windows CI tests into build and test#6
tomato wants to merge 1 commit into
masterfrom
windows-executor-no-cache

Conversation

@tomato

@tomato tomato commented Dec 21, 2020

Copy link
Copy Markdown
Owner

Because the compiler-cli tests modify node_modules, this can cause
failures on windows CI specifically as node_modules are symlinked
to rather than copied. By running the test and build actions in
separate commands, all of the tests are built to be executed before
and tests are executed and modify the node_modules content.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@josephperrott
ci: separate the windows CI tests into build and test
3730b2c 
Because the compiler-cli tests modify node_modules, this can cause
failures on windows CI specifically as node_modules are symlinked
to rather than copied.  By running the test and build actions in
separate commands, all of the tests are built to be executed before
and tests are executed and modify the node_modules content.
@reviewmlbot

reviewmlbot Bot commented Dec 21, 2020

Copy link
Copy Markdown

Hello, your commit has a 89% probability of containing an issue
You could reduce this probability by getting a review from:
Keen Yee Liau, whose probability of having an issue in similar code is 73%
Andrew Seguin, whose probability of having an issue in similar code is 74%
Ben Lesh, whose probability of having an issue in similar code is 74%
Victor Savkin, whose probability of having an issue in similar code is 74%
Miško Hevery, whose probability of having an issue in similar code is 75%
Jason Teplitz, whose probability of having an issue in similar code is 75%
Kara Erickson, whose probability of having an issue in similar code is 76%
crisbeto, whose probability of having an issue in similar code is 76%
Olivier Combe, whose probability of having an issue in similar code is 77%
Andrew Kushnir, whose probability of having an issue in similar code is 77%
Stefanie Fluin, whose probability of having an issue in similar code is 78%
Victor Berchet, whose probability of having an issue in similar code is 79%
Matias Niemelä, whose probability of having an issue in similar code is 79%
Alan Agius, whose probability of having an issue in similar code is 80%
Tony Bove, whose probability of having an issue in similar code is 81%
Joao Dias, whose probability of having an issue in similar code is 81%
Ward Bell, whose probability of having an issue in similar code is 82%
Ayaz Hafiz, whose probability of having an issue in similar code is 82%
Joey Perrott, whose probability of having an issue in similar code is 83%
Judy Bogart, whose probability of having an issue in similar code is 83%

@tomato tomato closed this Dec 26, 2020
@tomato tomato reopened this Dec 26, 2020
@tomato tomato closed this Dec 26, 2020
@tomato tomato reopened this Dec 26, 2020
@tomato tomato closed this Dec 28, 2020
@tomato tomato reopened this Dec 28, 2020
@tomato tomato closed this Dec 28, 2020
@tomato tomato reopened this Dec 28, 2020
@reviewmlbot

reviewmlbot Bot commented Dec 28, 2020

Copy link
Copy Markdown

It looks like we've not been able to train a model on this repo. Check out why at www.solittlecode.com

@tomato tomato closed this Dec 28, 2020
@tomato tomato reopened this Dec 28, 2020
@reviewmlbot

reviewmlbot Bot commented Dec 28, 2020

Copy link
Copy Markdown

Hello, your commit has a 89% probability of containing an issue
You could reduce this probability by getting a review from:
Keen Yee Liau, whose probability of having an issue in similar code is 73%
Andrew Seguin, whose probability of having an issue in similar code is 74%
Ben Lesh, whose probability of having an issue in similar code is 74%
Victor Savkin, whose probability of having an issue in similar code is 74%
Miško Hevery, whose probability of having an issue in similar code is 75%
View your dashboard at www.solittlecode.com

@tomato tomato closed this Dec 28, 2020
@tomato tomato reopened this Dec 28, 2020
@reviewmlbot

reviewmlbot Bot commented Dec 28, 2020

Copy link
Copy Markdown

Hello, your commit has a 89% probability of containing an issue
You could reduce this probability by getting a review from:
Keen Yee Liau, whose probability of having an issue in similar code is 73%
Andrew Seguin, whose probability of having an issue in similar code is 74%
Ben Lesh, whose probability of having an issue in similar code is 74%
Victor Savkin, whose probability of having an issue in similar code is 74%
Miško Hevery, whose probability of having an issue in similar code is 75%
View your dashboard at www.solittlecode.com

@solittlecode-reviewml

solittlecode-reviewml Bot commented Dec 28, 2020

Copy link
Copy Markdown

Hello, your commit has a 84% probability of containing an issue
You could reduce this probability by getting a review from:
George Kalpakas, whose probability of having an issue in similar code is 47%
Brandon Roberts, whose probability of having an issue in similar code is 50%
Kapunahele Wong, whose probability of having an issue in similar code is 52%
Alex Rickabaugh, whose probability of having an issue in similar code is 53%
Feliks Khantsis, whose probability of having an issue in similar code is 54%
View your dashboard at www.solittlecode.com

@tomato tomato closed this Dec 28, 2020
@tomato tomato reopened this Dec 28, 2020
@solittlecode-reviewml

solittlecode-reviewml Bot commented Dec 28, 2020

Copy link
Copy Markdown

Hello, your commit has a 84% probability of containing an issue
You could reduce this probability by getting a review from:
George Kalpakas, whose probability of having an issue in similar code is 47%
Brandon Roberts, whose probability of having an issue in similar code is 50%
Kapunahele Wong, whose probability of having an issue in similar code is 52%
Alex Rickabaugh, whose probability of having an issue in similar code is 53%
Feliks Khantsis, whose probability of having an issue in similar code is 54%
View your dashboard at www.solittlecode.com

@reviewmlbot

reviewmlbot Bot commented Dec 28, 2020

Copy link
Copy Markdown

Hello, your commit has a 89% probability of containing an issue
You could reduce this probability by getting a review from:
Keen Yee Liau, whose probability of having an issue in similar code is 73%
Andrew Seguin, whose probability of having an issue in similar code is 74%
Ben Lesh, whose probability of having an issue in similar code is 74%
Victor Savkin, whose probability of having an issue in similar code is 74%
Miško Hevery, whose probability of having an issue in similar code is 75%
View your dashboard at www.solittlecode.com

5 similar comments
@reviewmlbot

reviewmlbot Bot commented Dec 30, 2020

Copy link
Copy Markdown

Hello, your commit has a 89% probability of containing an issue
You could reduce this probability by getting a review from:
Keen Yee Liau, whose probability of having an issue in similar code is 73%
Andrew Seguin, whose probability of having an issue in similar code is 74%
Ben Lesh, whose probability of having an issue in similar code is 74%
Victor Savkin, whose probability of having an issue in similar code is 74%
Miško Hevery, whose probability of having an issue in similar code is 75%
View your dashboard at www.solittlecode.com

@reviewmlbot

reviewmlbot Bot commented Dec 30, 2020

Copy link
Copy Markdown

Hello, your commit has a 89% probability of containing an issue
You could reduce this probability by getting a review from:
Keen Yee Liau, whose probability of having an issue in similar code is 73%
Andrew Seguin, whose probability of having an issue in similar code is 74%
Ben Lesh, whose probability of having an issue in similar code is 74%
Victor Savkin, whose probability of having an issue in similar code is 74%
Miško Hevery, whose probability of having an issue in similar code is 75%
View your dashboard at www.solittlecode.com

@reviewmlbot

reviewmlbot Bot commented Dec 30, 2020

Copy link
Copy Markdown

Hello, your commit has a 89% probability of containing an issue
You could reduce this probability by getting a review from:
Keen Yee Liau, whose probability of having an issue in similar code is 73%
Andrew Seguin, whose probability of having an issue in similar code is 74%
Ben Lesh, whose probability of having an issue in similar code is 74%
Victor Savkin, whose probability of having an issue in similar code is 74%
Miško Hevery, whose probability of having an issue in similar code is 75%
View your dashboard at www.solittlecode.com

@reviewmlbot

reviewmlbot Bot commented Dec 30, 2020

Copy link
Copy Markdown

Hello, your commit has a 89% probability of containing an issue
You could reduce this probability by getting a review from:
Keen Yee Liau, whose probability of having an issue in similar code is 73%
Andrew Seguin, whose probability of having an issue in similar code is 74%
Ben Lesh, whose probability of having an issue in similar code is 74%
Victor Savkin, whose probability of having an issue in similar code is 74%
Miško Hevery, whose probability of having an issue in similar code is 75%
View your dashboard at www.solittlecode.com

@reviewmlbot

reviewmlbot Bot commented Dec 30, 2020

Copy link
Copy Markdown

Hello, your commit has a 89% probability of containing an issue
You could reduce this probability by getting a review from:
Keen Yee Liau, whose probability of having an issue in similar code is 73%
Andrew Seguin, whose probability of having an issue in similar code is 74%
Ben Lesh, whose probability of having an issue in similar code is 74%
Victor Savkin, whose probability of having an issue in similar code is 74%
Miško Hevery, whose probability of having an issue in similar code is 75%
View your dashboard at www.solittlecode.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomato @josephperrott