Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tmunzer/mistapi_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: tmunzer/mistapi_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feat/utilresponse-ws-error
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 5 files changed
  • 2 contributors

Commits on Jun 15, 2026

  1. feat(device_utils): surface WebSocket errors on UtilResponse (closes #29 

    )

UtilResponse gains ws_error / ws_close_code so a consumer can distinguish a
clean WebSocket completion from an errored, abnormally-closed, or
never-started one (previously the error was only logged and discarded):
- on_error records the first transport error (was a discard-only lambda);
- _on_close records the close code and flags a non-1000 abnormal close;
- start_with_trigger records ws_error when the WS factory returns None or
  raises during setup.

Additive and backward-compatible: ws_error stays None on a clean completion
or a trigger-only command. Adds unit tests for each path.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
    @tmunzer-AIDE @claude
    tmunzer-AIDE and claude committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    6e11316 View commit details
    Browse the repository at this point in the history

  2. docs(changelog): note ws_error/ws_close_code on UtilResponse (#29)

    @tmunzer-AIDE
    tmunzer-AIDE committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    a41c73a View commit details
    Browse the repository at this point in the history

  3. chore(release): bump version to 0.63.1

    @tmunzer-AIDE
    tmunzer-AIDE committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    d01e112 View commit details
    Browse the repository at this point in the history

  4. refactor(device_utils): address Copilot review on ws_error capture 

    - Guard the WS-factory-None ws_error assignment (first-write-wins, matching
  _on_error / _on_close).
- Neutralize the except-path ws_error message ('trigger/WebSocket setup
  error') since that except also wraps trigger_fn(), not only WS setup.
    @tmunzer-AIDE
    tmunzer-AIDE committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    2b0f39d View commit details
    Browse the repository at this point in the history
Loading