Thread IDs are Strings, not Integer

claudiob · claudiob · commit 5c0c84e576ce · 2013-10-21T09:02:22.000-07:00
The THREAD resource (used to document Notifications) states that the ID is returned as an Integer, where in fact is returned as a String. For instance, if I run curl -u [KEY]:x-oauth-basic https://api.github.com/notifications I obtain the following result (truncated): [ { "id": "18765913", "unread": true, "reason": "mention", "updated_at": "2013-10-21T15:52:16Z", "last_read_at": null, ... } ]
diff --git a/lib/resources.rb b/lib/resources.rb
@@ -1535,7 +1535,7 @@ def text_html(response, status, head = {})
     }
 
     THREAD = {
-      :id => 1,
+      :id => "1",
       :repository => SIMPLE_REPO,
       :subject => {
         :title => "Greetings",

Original file line number	Diff line number	Diff line change
`@@ -1535,7 +1535,7 @@ def text_html(response, status, head = {})`
`1535`	`1535`	`}`
`1536`	`1536`
`1537`	`1537`	`THREAD = {`
`1538`		`- :id => 1,`
	`1538`	`+ :id => "1",`
`1539`	`1539`	`:repository => SIMPLE_REPO,`
`1540`	`1540`	`:subject => {`
`1541`	`1541`	`:title => "Greetings",`