Skip to content

Conversation

@characat0
Copy link
Contributor

In some cases, the Backend.svd method will be called (ie. when using SparseBackend that does not implement it).
In those cases, the keyword argument full_matrices is present, but not expected.

This will still throw an error, but the NotImplementedError error is more informative than

TypeError: Backend.svd() got an unexpected keyword argument 'full_matrices'

@JeanKossaifi
Copy link
Member

That looks good to me, thanks @characat0!

@JeanKossaifi JeanKossaifi merged commit d4652c8 into tensorly:main Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants