Skip to content

Conversation

@caglayantuna
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #381 (56f621d) into main (15b3ba0) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   88.27%   88.33%   +0.06%     
==========================================
  Files         105      105              
  Lines        6131     6131              
==========================================
+ Hits         5412     5416       +4     
+ Misses        719      715       -4     
Impacted Files Coverage Δ
tensorly/tenalg/proximal.py 67.68% <0.00%> (+0.23%) ⬆️
tensorly/decomposition/_cp.py 88.68% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b3ba0...56f621d. Read the comment docs.

@JeanKossaifi
Copy link
Member

Looks good, thanks @caglayantuna, merging.

@JeanKossaifi JeanKossaifi merged commit 9e3df6e into tensorly:main Feb 19, 2022
@caglayantuna caglayantuna deleted the add_log branch February 23, 2022 08:15
@j6k4m8
Copy link
Contributor

j6k4m8 commented Mar 28, 2022

I think this still needs to be added to the top-level backend method import list, unless I'm misunderstanding?

@j6k4m8 j6k4m8 mentioned this pull request Mar 28, 2022
3 tasks
@JeanKossaifi
Copy link
Member

Yes, good point, thanks @j6k4m8!
Would be great to have a small PR for that and perhaps add some doc on how to add new functionalities to the backend.

@j6k4m8
Copy link
Contributor

j6k4m8 commented Mar 28, 2022

You got it!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants