Skip to content

Conversation

@merajhashemi
Copy link
Member

This pr fixes #246.

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #247 (4e66afb) into main (99d4004) will decrease coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   87.03%   86.43%   -0.61%     
==========================================
  Files          89       89              
  Lines        4426     4429       +3     
==========================================
- Hits         3852     3828      -24     
- Misses        574      601      +27     
Impacted Files Coverage Δ
tensorly/cp_tensor.py 85.02% <ø> (ø)
tensorly/decomposition/_cp.py 77.60% <100.00%> (ø)
tensorly/contrib/sparse/tests/test_tenalg.py 29.41% <0.00%> (-70.59%) ⬇️
...ensorly/contrib/sparse/tests/test_decomposition.py 41.17% <0.00%> (-58.83%) ⬇️
tensorly/contrib/sparse/core.py 75.00% <0.00%> (-25.00%) ⬇️
tensorly/tenalg/einsum_tenalg/outer_product.py 22.22% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d4004...4e66afb. Read the comment docs.

@JeanKossaifi
Copy link
Member

Thanks @merajhashemi !

@JeanKossaifi JeanKossaifi merged commit 9d79811 into tensorly:main Mar 22, 2021
@merajhashemi merajhashemi deleted the mh-complexcp branch March 28, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complex Support

2 participants