restruct sentry proj#79
Open
bkodes wants to merge 4 commits into
Open
Conversation
|
|
cretz
reviewed
Jul 24, 2023
cretz
left a comment
cretz
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Moving workflows to a separate file is definitely a good thing these days. Just need to get that activity back in there and I think we'll be good.
cretz
reviewed
Jul 24, 2023
cretz
left a comment
cretz
left a comment
Contributor
There was a problem hiding this comment.
Please make sure you run poe lint before pushing (poe format will fix the formatting issues)
Contributor
There was a problem hiding this comment.
I think you should update the starter.py to reference the workflow from this file and not through the worker.py file
Co-authored-by: Chad Retz <[email protected]>
Co-authored-by: Chad Retz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in /sentry currently does not run.
Separating the workflow code into its own file resolves the issue
What was changed
Moved greetings workflow to workflows.py and import workflow within worker
Why?
So others can reference this sample and have no issue running it without alterations being made
Checklist
Closes
How was this tested:
Followed run instructions in README.md. Outputs:
No