Add Strands plugin samples#310
Merged
Merged
Conversation
Demonstrates the Temporal Strands plugin: hello world, tools (in-workflow, custom activity, strands_tools), HITL, hooks, MCP, structured output, streaming, interrupt, and continue-as-new. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
`user_says` → `turn`, now a `@workflow.update` returning the assistant's reply directly so callers no longer need a separate `messages` query to discover what the agent said. The run loop drains in-flight handlers via `workflow.all_handlers_finished` before continue-as-new. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
The activity was toggling its `_APPROVED` state (add on raise, discard on success), so after the human approved once, a follow-up tool call from the model would interrupt again with no further approval coming — hanging the test. Drop the discard so once approved, the name stays approved. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
ruff's `I001` rule groups `temporalio` with other third-party imports rather than its own block, which broke `poe lint` on CI. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
brianstrauch
force-pushed
the
strands-plugin-samples
branch
from
1e8e365 to
1faf2fe
Compare
# Conflicts: # pyproject.toml # uv.lock
Picks up c84320c6 on the strands branch, which rewrites the MCP populate_cache and call_tool activity to use ClientSession directly instead of MCPClient.start/stop. The old code created a background event loop on one thread and closed it from another, which deadlocked mcp_test on Python 3.10 once trio_asyncio's policy was installed at import time by tests/trio_async/workflow_test.py. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Disambiguates from the hook-based human_in_the_loop sample by naming this one after where the interrupt is raised (a Temporal activity). Also fixes the parent README's broken `tool_interrupt` link. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
xumaple
requested changes
Jun 1, 2026
The dependency group is named strands-agents, not strands. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Replace test_continue_as_new_chat, which never tripped the continue-as-new branch, with test_continue_as_new_carries_history. A low limit.historyCount.suggestContinueAsNew threshold makes the server suggest continue-as-new after one turn, so the test verifies the original run ends in CONTINUED_AS_NEW and the fresh run resumes with the carried-over messages before taking another turn and ending the chat. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
xumaple
approved these changes
Jun 1, 2026
# Conflicts: # pyproject.toml # uv.lock
temporalio 1.28.0's langsmith extra already pins langsmith>=0.7.34,<0.9, so the manual constraint-dependencies entry is redundant. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
ruff format requires two blank lines before the trailing @@@SNIPEND markers added in 12f9d5d. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
xumaple
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strands_plugin/directory with samples for the Temporal Strands plugin: hello world, tools (in-workflow@tool,activity_as_tool,strands_toolswrapped as activity), human-in-the-loop, hooks, MCP, structured output, streaming, tool interrupt, and continue-as-new.tests/strands_plugin/with a shared_mock_modelso the suite runs without hitting a real model.strandsextra inpyproject.tomlfor the sample dependencies.Test plan
uv sync --group strandsuv run pytest tests/strands_pluginhello_world,tools, andmcpsamples end-to-end against a local Temporal server🤖 Generated with Claude Code