Skip to content

Rename folders to match package name#22

Merged
tomwheeler merged 2 commits into
temporalio:mainfrom
justinjwesley-enlighten:main
Jan 14, 2026
Merged

Rename folders to match package name#22
tomwheeler merged 2 commits into
temporalio:mainfrom
justinjwesley-enlighten:main

Conversation

@justinjwesley-enlighten

@justinjwesley-enlighten justinjwesley-enlighten commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

What was changed

Changed the name of the "versionworkflow" folder to "getversion" in the java/test folders of each project in this workspace to match the package name in all the classes.

Why?

While not a strict requirement in Java, not following the convention for naming the folder and package the same is opening up for many unpredictable errors. IDEs like IntelliJ don't like this as well. It is just a good practice.

Checklist

  1. Closes

  2. How was this tested:

Ran mvn clean test in each project

  1. Any docs updates needed?

@justinjwesley-enlighten justinjwesley-enlighten requested a review from a team as a code owner January 13, 2026 21:17
@CLAassistant

CLAassistant commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@justinjwesley-enlighten

justinjwesley-enlighten commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I can't seem to submit a CLA request. :(

@tomwheeler

tomwheeler commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Hi @justinjwesley-enlighten could you please elaborate on the problem you've experienced signing the CLA? I want to make sure we get that fixed, particularly if this isn't an isolated incident.

I can confirm (and apologize for) the problem you've reported, so you can count on me approving the PR as quickly as we can work out the problem with the CLA.

@justinjwesley-enlighten

justinjwesley-enlighten commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

Hi @justinjwesley-enlighten could you please elaborate on the problem you've experienced signing the CLA? I want to make sure we get that fixed, particularly if this isn't an isolated incident.

I can confirm (and apologize for) the problem you've reported, so you can count on me approving the PR as quickly as we can work out the problem with the CLA.

It wasn't loading the agreement this morning, so I couldn't click anything. I just tried again and submitted my agreement.

tomwheeler
tomwheeler approved these changes Jan 14, 2026
View reviewed changes

@tomwheeler tomwheeler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes and also tested the updated exercise code in a GitHub Codespace.

@tomwheeler

tomwheeler commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Thank you very much for the contribution, @justinjwesley-enlighten! I have approved the PR and will now merge in the changes.

@tomwheeler tomwheeler merged commit 24d8f96 into temporalio:main Jan 14, 2026
3 checks passed
@tomwheeler tomwheeler mentioned this pull request Jan 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomwheeler tomwheeler tomwheeler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinjwesley-enlighten @CLAassistant @tomwheeler