fix(api-server): send initial SSE event to complete handshake#10159
Merged
davidfirst merged 2 commits intomasterfrom Jan 16, 2026
Merged
fix(api-server): send initial SSE event to complete handshake#10159davidfirst merged 2 commits intomasterfrom
davidfirst merged 2 commits intomasterfrom
Conversation
Some EventSource clients stay in CONNECTING state until they receive data. Sending an initial 'connected' event ensures proper handshake completion.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where some EventSource clients (like the eventsource npm package used in VS Code extensions) remain in CONNECTING state indefinitely. The fix adds an initial connected event immediately after sending SSE headers to complete the handshake.
Changes:
- Adds an initial SSE event (
event: connected\ndata: {}\n\n) immediately after writing response headers to ensure proper EventSource client handshake completion
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luvkapur
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some EventSource clients (like the
eventsourcenpm package used in VS Code extension) stay in CONNECTING state until they receive data from the server.This adds an initial
connectedevent immediately after sending the SSE headers, ensuring proper handshake completion and allowing clients to transition to OPEN state.Before: EventSource stays in
readyState: 0 (CONNECTING)indefinitelyAfter: EventSource transitions to
readyState: 1 (OPEN)immediately