refactor: remove legacy relativePaths handling code#10024
Merged
davidfirst merged 9 commits intomasterfrom Oct 6, 2025
Merged
Conversation
Since Harmony (schema 2.0.0+), relativePaths in dependencies is always empty and validated to be so. Legacy components with relativePaths would have broken on many other things by now. Removed: - relativePaths from Version.id() hash calculation - Complex relativePaths validation in Dependencies.validate() - relativePaths diff display in component-diff The final Version validator still checks relativePaths is empty as a safety net.
Removed tests for relativePaths validation since it's no longer validated in Dependencies.validate() - relativePaths is always empty for Harmony components and validated at the Version level.
luvkapur
approved these changes
Oct 3, 2025
Removed tests expecting relativePaths in Version.id() output since it's no longer included in the hash calculation for Harmony components.
…ativepaths-legacy-code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unnecessary legacy code for handling in dependencies, which has been obsolete since Harmony (schema 2.0.0+).
Background
Since Harmony, in dependencies is always empty and validated to be so. Any legacy components with would have broken on many other things by now and never use this version.
Changes
Safety
The final Version validator still checks that is empty as a safety net, ensuring components with relative imports are caught before reaching the Version object.