datetime: fix minimal supported epoch (2) #12189
Draft
+531
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmr-g
force-pushed
the
i12156-2
branch
4 times, most recently
from
0240d08 to
3b06138
Compare
- The epoch seconds value parsed with `'%s'` by `datetime.parse()` isn't ignored and used now as a timestamp value by `datetime.new()`. - The zero value doesn't produce an error. Closes tarantool#12143 NO_DOC=bugfix
Now `datetime.new()` and `datetime_object:set()` check timestamp value to be in valid range. Out of range timestamps produce an error instead of assertion failure. Closes tarantool#12147 NO_DOC=bugfix
Constants `MIN_TZOFFSET` and `MAX_TZOFFSET` are introduced in `datetime.lua` and in Lua test modules for better evolvability. NO_CHANGELOG=no visible changes NO_TEST=no new behavior NO_DOC=no new behavior
TODO: descr Closes tarantool#12156 NO_DOC=bugfix NO_CHANGELOG=fixme TODO: tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: descr
Closes #12156, #10704
NO_DOC=bugfix
NO_CHANGELOG=fixme
TODO: tests