refactor(syncthing): use slogutil expensive wrapper for CPU benchmark #10471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves consistency and makes it a bit easier to change the log level to something else. Signed-off-by: Marcus B Spencer <[email protected]>
Member
|
Yes possibly. This had me thinking a bit because it moves the computation to the logging framework, effectively, and I realized there is a bug because we format twice in different ways (internal + stdout), so index 27844d546..e3f19a59e 100644
--- i/cmd/syncthing/main.go
+++ w/cmd/syncthing/main.go
@@ -51,6 +51,7 @@ import (
"github.com/syncthing/syncthing/lib/locations"
"github.com/syncthing/syncthing/lib/osutil"
"github.com/syncthing/syncthing/lib/protocol"
+ "github.com/syncthing/syncthing/lib/rand"
"github.com/syncthing/syncthing/lib/svcutil"
"github.com/syncthing/syncthing/lib/syncthing"
"github.com/syncthing/syncthing/lib/upgrade"
@@ -429,6 +430,12 @@ func (c *serveCmd) syncthingMain() {
startPerfStats()
}
+ slog.Info("Expensive stuff", "exp", slogutil.Expensive(func() any {
+ v := rand.String(8)
+ fmt.Println("computed:", v)
+ return v
+ }))
+
// Print our version information up front, so any crash that happens
// early etc. will have it available.
slog.Info(build.LongVersion) //nolint:sloglintthat should be fixed probably first... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improves consistency and makes it a bit easier to change the log level to something else.
Testing
CPU benchmark looks like it works and has the same format as before.