Skip to content

Conversation

@Kocal
Copy link
Contributor

@Kocal Kocal commented Dec 25, 2025

Both Symfony and Symfony UX repositories use Twig-CS-Fixer to lint and reformat Twig files, I think it could be a nice idea to put it here in Fabbot

@Kocal
Copy link
Contributor Author

Kocal commented Dec 25, 2025

I noticed in https://github.com/symfony/symfony/blob/8.1/.github/workflows/twig-cs-fixer.yml that we are defining COMPOSER_ROOT_VERSION from src/Symfony/Component/HttpKernel/Kernel.php, do we agree it's specific only to Symfony repository and it's not needed here?

Copy link

@94noni 94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one indeed

@Kocal
Copy link
Contributor Author

Kocal commented Dec 29, 2025

cc @nicolas-grekas 🙏🏻

Kocal added a commit to symfony/ux that referenced this pull request Dec 30, 2025
…Kocal)

This PR was merged into the 2.x branch.

Discussion
----------

 Truly leverage PHP-CS-Fixer and Twig-CS-Fixer to Fabbot

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

Follows #3249.

This PR move all PHP-CS-Fixer and Twig-CS-Fixer configuration files (except the one from `ux.symfony.com/`), and now runs on `src/*` and `apps/*`, thanks to Fabbot.

It requires symfony-tools/fabbot#12 for Twig files

Commits
-------

823d5fd Truly leverage PHP-CS-Fixer and Twig-CS-Fixer to Fabbot
symfony-splitter pushed a commit to symfony/ux-toolkit that referenced this pull request Dec 30, 2025
…Kocal)

This PR was merged into the 2.x branch.

Discussion
----------

 Truly leverage PHP-CS-Fixer and Twig-CS-Fixer to Fabbot

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

Follows symfony/ux#3249.

This PR move all PHP-CS-Fixer and Twig-CS-Fixer configuration files (except the one from `ux.symfony.com/`), and now runs on `src/*` and `apps/*`, thanks to Fabbot.

It requires symfony-tools/fabbot#12 for Twig files

Commits
-------

823d5fd6dd3 Truly leverage PHP-CS-Fixer and Twig-CS-Fixer to Fabbot
@nicolas-grekas nicolas-grekas merged commit d0abdfc into symfony-tools:main Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants