Forward -ipi-clang-module to the frontend#2145
Conversation
|
@swift-ci please test |
sepy97
requested review from
DougGregor,
artemcm,
cachemeifyoucan,
compnerd and
owenv
as code owners
| public static let internalImportPch: Option = Option("-internal-import-pch", .separate, attributes: [.helpHidden, .frontend, .argumentIsPath], helpText: "Import bridging header PCH file as internal") | ||
| public static let internalizeAtLink: Option = Option("-internalize-at-link", .flag, attributes: [.helpHidden, .frontend, .noDriver], helpText: "Allow internalizing public symbols and vtables at link time (assume all client code of public types is part of the same link unit, or that external symbols are explicitly requested via -exported_symbols_list)") | ||
| public static let interpret: Option = Option("-interpret", .flag, attributes: [.helpHidden, .frontend, .noDriver], helpText: "Immediate mode", group: .modes) | ||
| public static let ipiClangModule: Option = Option("-ipi-clang-module", .separate, attributes: [.helpHidden, .frontend], metaVar: "<name>", helpText: "Mark a Clang module by name as project-internal (IPI). Public imports of the named module will be diagnosed.") |
There was a problem hiding this comment.
This file is auto-generated (see readme). Do not hand-modify this file.
There was a problem hiding this comment.
Updated the Options following README directions
There was a problem hiding this comment.
Ah, damn, the option update is breaking the newly added license header check. Feel free to do a hand fix of license header for now. Let me update makeOptions to generate the correct header.
There was a problem hiding this comment.
Ah, it is fixed in 87f4951bc0d7ad3abe1fbdb159441fe8175ec04b already. Just sync to main before you build makeOption.
There was a problem hiding this comment.
By a hand fix you mean reverting lines 1, 10, and 11?
sepy97
force-pushed
the
ipi-clang-module-flag
branch
from
e161077 to
61f1d83
Compare
|
@swift-ci please test |
sepy97
force-pushed
the
ipi-clang-module-flag
branch
2 times, most recently
from
7868050 to
4cc36aa
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test Windows |
|
@swift-ci please test Windows Platform |
sepy97
force-pushed
the
ipi-clang-module-flag
branch
from
4cc36aa to
5c0d70b
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test Windows Platform |
1 similar comment
|
@swift-ci please smoke test Windows Platform |
|
@swift-ci please test Windows Platform |
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
One file accidentally checked it. Otherwise LGTM.
| @@ -0,0 +1,159 @@ | |||
| diff --git a/Sources/SwiftOptions/Options.swift b/Sources/SwiftOptions/Options.swift | |||
There was a problem hiding this comment.
This file should not be here!!!
Add the `Option.ipiClangModule` definition and forward the ipi clang module names to the frontend. Update the Options file rdar://178067059
sepy97
force-pushed
the
ipi-clang-module-flag
branch
from
5c0d70b to
ae6ed4f
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows Platform |
3 participants
Add the
Option.ipiClangModuledefinition and forward the ipi clang module names to the frontend.rdar://178067059