Fix #11007 FP nullPointerRedundantCheck with static function pointer (cppcheck-opensource#4051)

chrchr-github · web-flow · commit 0dc3cb6eba36 · 2022-04-26T17:25:56.000+02:00
diff --git a/lib/checknullpointer.cpp b/lib/checknullpointer.cpp
@@ -182,8 +182,13 @@ bool CheckNullPointer::isPointerDeRef(const Token *tok, bool &unknown, const Set
         return false;
 
     // Dereferencing pointer..
-    if (parent->isUnaryOp("*") && !addressOf)
-        return true;
+    if (parent->isUnaryOp("*")) {
+        // declaration of function pointer
+        if (tok->variable() && tok->variable()->nameToken() == tok)
+            return false;
+        if (!addressOf)
+            return true;
+    }
 
     // array access
     if (firstOperand && parent->str() == "[" && !addressOf)
diff --git a/test/testnullpointer.cpp b/test/testnullpointer.cpp
@@ -1137,6 +1137,15 @@ class TestNullPointer : public TestFixture {
               "}");
         ASSERT_EQUALS("[test.cpp:5]: (error) Null pointer dereference: f\n", errout.str());
 
+        check("int* g();\n" // #11007
+              "int* f() {\n"
+              "    static int* (*fun)() = 0;\n"
+              "    if (!fun)\n"
+              "        fun = g;\n"
+              "    return fun();\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
+
         // loops..
         check("void f() {\n"
               "    int *p = 0;\n"
