Fix pasteHTML issue #3706
Merged
Fix pasteHTML issue #3706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dom.splitPointis called and it creates empty node(<p><br></p>). Actually, we don't need to create it but the empty node is needed for placing the caret. Without an empty node, user cannot place their caret where they would be.dom.splitPointcreates a lot of empty paragraph while processing nodes. So fixed not using p-br tag #3498 added checking logic for empty nodes but it causes another issue which is described on DOMException: Failed to execute 'setEnd' on 'Range' #3678.dom.splitPointafter inserting new nodes when it should be deleted.What are the relevant tickets?
Checklist