Skip to content

Conversation

@JoniJnm
Copy link

@JoniJnm JoniJnm commented Sep 22, 2016

What does this PR do?

  • Allow hint multiple words (the current only one word)

Where should the reviewer start?

  • start on the src/summernote.js

How should this be manually tested?

  • There is a example in examples/hint-words.html (needs grunt dist first!)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 70.263% when pulling 55d5ec3 on bebeeteam:change/hint-words into 5042a63 on summernote:develop.

@hackerwins hackerwins requested a review from easylogic August 28, 2017 11:50
@lqez
Copy link
Member

lqez commented Nov 14, 2017

LGTM

@fxa76
Copy link

fxa76 commented Jun 4, 2018

Hi,

Is there any chance the multiple words hint moves forward ?

@fxa76
Copy link

fxa76 commented Jun 12, 2018

Hi Again,

Following my comment on Slack.

This feature is very important to me, as I am uing it for names and also events. In my case there can be many records that start with the same word and would like to enable typing more than one word to get the proper hint. For example :
names :
James_Hetfield
James_Lebron.
Etc..
Events :
Festival Download
Festival de Cannes
Festival de Robotique

I am also using it to enable creation of a names or event that is not in the database yet

@lqez lqez self-assigned this Sep 6, 2018
@lqez lqez assigned easylogic and unassigned lqez Oct 30, 2018
@lqez
Copy link
Member

lqez commented Oct 30, 2018

@easylogic will handle this PR. Thanks.

@Marcelo-Petrucelli
Copy link

Any progress in this PR? It would be very useful.

@sburkett
Copy link

sburkett commented Nov 1, 2019

Just wanted to say that this sort of functionality is also incredibly important to me as well, since my need is to provide hints for products and items, such as:

Apples, Macintosh
Apples, Golden
Apples, Granny Smith
etc.

I really hope this moves forward at some point!

@lqez lqez force-pushed the develop branch 2 times, most recently from c3cfdd5 to d3b48e5 Compare December 14, 2019 07:21
@lqez lqez merged commit 55d5ec3 into summernote:develop Dec 27, 2019
@lqez
Copy link
Member

lqez commented Dec 27, 2019

I manually merged, thanks.

@JoniJnm JoniJnm deleted the change/hint-words branch January 27, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants