fix(renderer): debounce renders, refactor scroll logic, track scrollintent#280
Open
jensenojs wants to merge 1 commit intosudo-tee:mainfrom
Open
fix(renderer): debounce renders, refactor scroll logic, track scrollintent#280jensenojs wants to merge 1 commit intosudo-tee:mainfrom
jensenojs wants to merge 1 commit intosudo-tee:mainfrom
Conversation
…intent Three related improvements to output rendering: 1. Debounce concurrent render_full_session calls Problem: Rapid session switches trigger multiple redundant renders. Solution: Coalesce into one in-flight render + trailing render with latest options. 2. Refactor scroll_to_bottom conditions Convert nested if-else chain to declarative condition table for better readability and maintainability. 3. Add WinScrolled autocmd Track user scroll position to accurately detect scroll intent (whether user is at bottom or has scrolled up).
Contributor
Author
|
These accumulated organically while building persist_state—fixing bugs, cleaning up code, adding small enhancements to get the experience right. Even with LLM assistance, splitting them now would be a headache. My apologies for the bundled review. @sudo-tee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.