fix(question_window): avoid duplicate 'other' option#279
Open
disrupted wants to merge 7 commits intosudo-tee:mainfrom
Open
fix(question_window): avoid duplicate 'other' option#279disrupted wants to merge 7 commits intosudo-tee:mainfrom
disrupted wants to merge 7 commits intosudo-tee:mainfrom
Conversation
disrupted
commented
Feb 14, 2026
Comment on lines
489
to
493
| @@ -490,9 +490,9 @@ | |||
| " 2. plenary.nvim - Plenary.nvim provides unit test utilities for Neovim plugins.", | |||
| " 3. other - Other or custom test framework", | |||
| "", | |||
| "Navigate: `j`/`k` or `↑`/`↓` Select: `<CR>` or `1-3` Dismiss: `<Esc>`", | |||
| "Navigate: `j`/`k` or `↑`/`↓` Select: `<CR>` or `1-4` Dismiss: `<Esc>`", | |||
Contributor
Author
There was a problem hiding this comment.
hm, this still looks off...
Contributor
Author
There was a problem hiding this comment.
for some reason it seems to add a duplicate 'other' option (no. 5)
Contributor
Author
There was a problem hiding this comment.
found the issue. I would also like to add a new replay test to cover this before this gets merged
disrupted
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.