unit tests

panticmilos · panticmilos · commit fd1b409bc3ad · 2022-05-19T17:33:13.000+02:00
diff --git a/__tests__/installer.test.ts b/__tests__/installer.test.ts
@@ -913,4 +913,31 @@ describe('setup-node', () => {
       }
     );
   });
+
+  describe('latest alias syntax from cache', () => {
+    it.each(['latest', 'current', 'node'])(
+      'download the %s version if alias is provided',
+      async inputVersion => {
+        // Arrange
+        inputs['node-version'] = inputVersion;
+        const expectedVersion = nodeTestDist[0];
+
+        os.platform = 'darwin';
+        os.arch = 'x64';
+
+        const toolPath = path.normalize(
+          `/cache/node/${expectedVersion.version}/x64`
+        );
+        findSpy.mockReturnValue(toolPath);
+
+        // Act
+        await main.run();
+
+        // assert
+        expect(logSpy).toHaveBeenCalledWith(`Found in cache @ ${toolPath}`);
+
+        expect(logSpy).toHaveBeenCalledWith('getting latest node version...');
+      }
+    );
+  });
 });
diff --git a/dist/setup/index.js b/dist/setup/index.js
@@ -62339,6 +62339,7 @@ const tc = __importStar(__webpack_require__(533));
 const path = __importStar(__webpack_require__(622));
 const semver = __importStar(__webpack_require__(280));
 const fs = __webpack_require__(747);
+const installer = __importStar(__webpack_require__(923));
 function getNode(versionSpec, stable, checkLatest, auth, arch = os.arch()) {
     return __awaiter(this, void 0, void 0, function* () {
         // Store manifest data to avoid multiple calls
@@ -62362,7 +62363,7 @@ function getNode(versionSpec, stable, checkLatest, auth, arch = os.arch()) {
                 core.info(`Failed to resolve version ${versionSpec} from manifest`);
             }
         }
-        if (['current', 'latest', 'node'].includes(versionSpec)) {
+        if (isLatestSyntax(versionSpec)) {
             versionSpec = yield queryDistForMatch(versionSpec, arch);
             core.info(`getting latest node version...`);
         }
@@ -62590,10 +62591,8 @@ function queryDistForMatch(versionSpec, arch = os.arch()) {
                 throw new Error(`Unexpected OS '${osPlat}'`);
         }
         let versions = [];
-        let nodeVersions = yield getVersionsFromDist();
-        if (versionSpec === 'current' ||
-            versionSpec === 'latest' ||
-            versionSpec === 'node') {
+        let nodeVersions = yield installer.getVersionsFromDist();
+        if (isLatestSyntax(versionSpec)) {
             core.info(`getting latest node version...`);
             return nodeVersions[0].version;
         }
@@ -62692,6 +62691,9 @@ function parseNodeVersionFile(contents) {
     return nodeVersion;
 }
 exports.parseNodeVersionFile = parseNodeVersionFile;
+function isLatestSyntax(versionSpec) {
+    return ['current', 'latest', 'node'].includes(versionSpec);
+}
 
 
 /***/ }),
diff --git a/src/installer.ts b/src/installer.ts
@@ -7,6 +7,7 @@ import * as tc from '@actions/tool-cache';
 import * as path from 'path';
 import * as semver from 'semver';
 import fs = require('fs');
+import * as installer from './installer';
 
 //
 // Node versions interface
@@ -66,8 +67,8 @@ export async function getNode(
     }
   }
 
-  if(['current', 'latest', 'node'].includes(versionSpec)) {
-    versionSpec = await queryDistForMatch(versionSpec, arch); 
+  if (isLatestSyntax(versionSpec)) {
+    versionSpec = await queryDistForMatch(versionSpec, arch);
     core.info(`getting latest node version...`);
   }
 
@@ -376,13 +377,9 @@ async function queryDistForMatch(
   }
 
   let versions: string[] = [];
-  let nodeVersions = await getVersionsFromDist();
+  let nodeVersions = await installer.getVersionsFromDist();
 
-  if (
-    versionSpec === 'current' ||
-    versionSpec === 'latest' ||
-    versionSpec === 'node'
-  ) {
+  if (isLatestSyntax(versionSpec)) {
     core.info(`getting latest node version...`);
     return nodeVersions[0].version;
   }
@@ -487,3 +484,7 @@ export function parseNodeVersionFile(contents: string): string {
   }
   return nodeVersion;
 }
+
+function isLatestSyntax(versionSpec): boolean {
+  return ['current', 'latest', 'node'].includes(versionSpec);
+}

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ import * as tc from '@actions/tool-cache';`
`7`	`7`	`import * as path from 'path';`
`8`	`8`	`import * as semver from 'semver';`
`9`	`9`	`import fs = require('fs');`
	`10`	`+import * as installer from './installer';`
`10`	`11`
`11`	`12`	`//`
`12`	`13`	`// Node versions interface`
`@@ -66,8 +67,8 @@ export async function getNode(`
`66`	`67`	`}`
`67`	`68`	`}`
`68`	`69`
`69`		`- if(['current', 'latest', 'node'].includes(versionSpec)) {`
`70`		`- versionSpec = await queryDistForMatch(versionSpec, arch);`
	`70`	`+ if (isLatestSyntax(versionSpec)) {`
	`71`	`+ versionSpec = await queryDistForMatch(versionSpec, arch);`
`71`	`72`	core.info(`getting latest node version...`);
`72`	`73`	`}`
`73`	`74`
`@@ -376,13 +377,9 @@ async function queryDistForMatch(`
`376`	`377`	`}`
`377`	`378`
`378`	`379`	`let versions: string[] = [];`
`379`		`- let nodeVersions = await getVersionsFromDist();`
	`380`	`+ let nodeVersions = await installer.getVersionsFromDist();`
`380`	`381`
`381`		`- if (`
`382`		`- versionSpec === 'current' \|\|`
`383`		`- versionSpec === 'latest' \|\|`
`384`		`- versionSpec === 'node'`
`385`		`- ) {`
	`382`	`+ if (isLatestSyntax(versionSpec)) {`
`386`	`383`	core.info(`getting latest node version...`);
`387`	`384`	`return nodeVersions[0].version;`
`388`	`385`	`}`
`@@ -487,3 +484,7 @@ export function parseNodeVersionFile(contents: string): string {`
`487`	`484`	`}`
`488`	`485`	`return nodeVersion;`
`489`	`486`	`}`
	`487`	`+`
	`488`	`+function isLatestSyntax(versionSpec): boolean {`
	`489`	`+ return ['current', 'latest', 'node'].includes(versionSpec);`
	`490`	`+}`