Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

I had some small thoughts about the ebook reader. We could use this to set the brightness instead of it being fake? And the minimumTrackTintColor for the slider should probably be another colour so that you can actually see the brightness bar.

And with the new sheets, we could have like detents={[0.5]} and dimmed={false}, then the actual book's text itself seems like the perfect preview window?

@Arklaum I'm sorry, I totally missed this message in my inbox!

We could use this to set the brightness instead of it being fake?

Yeah I'm not opposed to that, originally I didn't go that route (and instead only applied it to the readium webview) so the settings don't become too dim.

And the minimumTrackTintColor for the slider should probably be another colour so that you can actually see the brightness bar

I'll add a couple new colors to the config for sliders

And with the new sheets, we could have like detents={[0.5]} and dimmed={false}, then the actual book's text itself seems like the perfect preview window?

I'll give it a try and see how it feels

Yeah I'm not opposed to that, originally I didn't go that route (and instead only applied it to the readium webview) so the settings don't become too dim.

I'm personally used to the actual device dimming. Apple Books and Google Play Books do it that way, but the Kindle app doesn't.

Stepper buttons that are separate like this look nice and also might be less likely to mess up pressing too:

Stepper buttons Before and After

Before	After

Would you like them?

And for the theme selector, if there were smaller previews you could have empty theme as a button for adding, and long press for a menu to delete or edit:

Example

Please feel free to push to this PR as you'd like! I really appreciate you spinning this up locally and taking a look!

Wrt the dimming, I don't have a strong lean either way tbh. So, if you feel more strongly with it I am totally good with that change.

Stepper buttons that are separate like this look nice and also might be less likely to mess up pressing too... Would you like them?

Yeah those look significantly better, eventually I was just going to use expo ui's stepper components (in main, not released last I checked) but those are great.

And for the theme selector, if there were smaller previews you could have empty theme as a button for adding, and long press for a menu to delete or edit

I love interaction design you suggested here a LOT more wrt the dashed border one to add another. I think a long press menu generally works a lot better on iOS, and often behaves a bit wonkier on Android, but I'm very good to try it out