Skip to content

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Aug 27, 2025

Describe your changes

Images in markdown are scaled in a way that they can become distorted:

Screenshot 2025-08-27 at 12 21 29

This PR ensures that images always keep the aspect ratio when there isn't enough space available.

Testing Plan

  • Updated e2e test.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Aug 27, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-12343/streamlit-1.48.1-py3-none-any.whl
🕹️ Preview app pr-12343.streamlit.app (☁️ Deploy here if not accessible)

@lukasmasuch lukasmasuch added security-assessment-completed Security assessment has been completed for PR change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels Aug 27, 2025
@lukasmasuch lukasmasuch marked this pull request as ready for review August 27, 2025 11:37
@lukasmasuch lukasmasuch merged commit de85c52 into develop Aug 27, 2025
37 checks passed
@lukasmasuch lukasmasuch deleted the fix/markdown-image-keep-aspect-ratio branch August 27, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants