plugins.ceskatelevize: fix stream import for ctsport#6826
plugins.ceskatelevize: fix stream import for ctsport#6826bastimeyer merged 1 commit intostreamlink:masterfrom
Conversation
|
Thanks for the PR. The changes are looking good, apart from the linting issues which need to be resolved before this can be merged. The streams are geo-blocked, but the initial HTTP request with the JSON payload inside the HTML response is accessible, so I guess these changes are fine according to what I could see. Please post a quick debug log with a working stream, just to be sure. Btw, the commit author/commiter data is not tied to your GH account. I'm not sure if this was intentional or not, but I thought I should mention it... |
|
I will fix the lint shortly, below is the debug output. What do you mean by the commit not being tied to my GH account? I can see myself as an author of the commit in the pull request... |
👍
The email address used as author and committer data is not part of your GH account, hence why GH can't link it to you. This doesn't matter, but I wanted to tell you, in case you were not aware. Some people do this intentionally, some simply have their git config misconfigured.
|
25602e2 to
5c7de40
Compare
|
Hey sorry I got busy this week and didn't get a chance to do the cleanup I promised.. |
Fixes #6823,
only by adjusting the xpaths to locate the stream for the sport channel. Tested and works.