Remove deprecated plugin.api/plugins import paths#6274
Merged
bastimeyer merged 2 commits intostreamlink:masterfrom Nov 1, 2024
Merged
Remove deprecated plugin.api/plugins import paths#6274bastimeyer merged 2 commits intostreamlink:masterfrom
bastimeyer merged 2 commits intostreamlink:masterfrom
Conversation
- remove deprecated `HTTPSession` from `streamlink.plugin.api` - remove deprecated `streamlink.plugin.api.http_session` module
bastimeyer
force-pushed
the
plugin/remove-deprecated-import-paths
branch
from
6f17b95 to
21e2b77
Compare
bastimeyer
force-pushed
the
plugin/remove-deprecated-import-paths
branch
from
21e2b77 to
62d3402
Compare
Remove deprecated re-exports from `streamlink.plugins` and update tests: - `NoPluginError` - `NoStreamsError` - `PluginError` - `Plugin`
bastimeyer
force-pushed
the
plugin/remove-deprecated-import-paths
branch
from
62d3402 to
3c2d88a
Compare
gravyboat
approved these changes
Nov 1, 2024
Member
gravyboat
left a comment
gravyboat
left a comment
There was a problem hiding this comment.
Nice. Documentation is very clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One PR for both removals... I will have to rebase with the updated PR number after submitting this one.
streamlink.plugin.api.HTTPSession,streamlink.plugin.api.http_session.{HTTPSession,TLSNoDHAdapter,TLSSecLevel1Adapter}were deprecated in session: re-organize session and http_session modules #5807 (6.6.0)streamlink.plugins.{NoPluginError,NoStreamsError,PluginError,Plugin}were deprecated for more than 10 years, with official deprecation warnings being added in plugins: officially deprecate re-exports #6005 (6.8.0)Even though some of these deprecation phases were rather short, it's time to remove this in the upcoming 7.0.0 release. It's a trivial change.