Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Fixed bug that displays social login titles without any providers#78

Merged
robertjd merged 1 commit into
stormpath:masterfrom
timothyej:fix-angular-social-bug
Nov 20, 2015
Merged

Fixed bug that displays social login titles without any providers#78
robertjd merged 1 commit into
stormpath:masterfrom
timothyej:fix-angular-social-bug

Conversation

@timothyej

Copy link
Copy Markdown
Contributor

Fixes a bug that made ng-show evaluate an empty array to false and display text related to social login, even though no social login providers were active.

How to verify

  1. Checkout this branch
  2. Copy the dist folder to your AngularJS app
  3. Make sure you are using the latest version of AngularJS
  4. Verify that the login and register forms doesn't display anything related to social login when no social providers are activated
  5. Add a Social Directory to your Stormpath Application
  6. Verify that the login and register forms displays buttons for the activated social provider

Screenshots

screen shot 2015-11-20 at 17 16 04

robertjd added a commit that referenced this pull request Nov 20, 2015
Fixed bug that displays social login titles without any providers
@robertjd robertjd merged commit 327ebf6 into stormpath:master Nov 20, 2015
@robertjd

Copy link
Copy Markdown
Member

Thanks @timothyej !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants