Skip to content

Commit f93c3b6

Browse files
committed
css fix: gutter > add height rule to 100% or gutterSize
1 parent 5fd8916 commit f93c3b6

4 files changed

Lines changed: 17 additions & 6 deletions

File tree

dist/splitGutter.directive.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ export declare class SplitGutterDirective {
55
order: number;
66
private _direction;
77
direction: string;
8-
size: any;
8+
private _size;
9+
size: number;
910
private _disabled;
1011
disabled: boolean;
1112
constructor(elementRef: ElementRef, renderer: Renderer);

dist/splitGutter.directive.js

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/splitGutter.directive.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/splitGutter.directive.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@ export class SplitGutterDirective {
1515
this.refreshStyle();
1616
}
1717

18-
@Input() set size(v) {
19-
this.setStyle('flex-basis', v + 'px');
18+
private _size: number;
19+
@Input() set size(v: number) {
20+
this._size = v;
21+
this.refreshStyle();
2022
}
2123

2224
private _disabled: boolean = false;
@@ -29,8 +31,12 @@ export class SplitGutterDirective {
2931
private renderer: Renderer) {}
3032

3133
private refreshStyle() {
32-
const state = this._disabled === true ? 'disabled' : this._direction;
34+
this.setStyle('flex-basis', `${ this._size }px`);
35+
36+
// fix safari bug about gutter height when direction is horizontal
37+
this.setStyle('height', (this._direction === 'horizontal') ? `${ this._size }px` : `100%`);
3338

39+
const state = (this._disabled === true) ? 'disabled' : this._direction;
3440
this.setStyle('cursor', this.getCursor(state));
3541
this.setStyle('background-image', `url("${ this.getImage(state) }")`);
3642
}

0 commit comments

Comments
 (0)