Encrypt api key and add readme for docker #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinnec
approved these changes
Jan 18, 2023
gcharis
force-pushed
the
deployment-docs
branch
from
0dbc097 to
ca8c19b
Compare
momegas
approved these changes
Jan 18, 2023
momegas
reviewed
Jan 25, 2023
Member
momegas
left a comment
momegas
left a comment
There was a problem hiding this comment.
Code wise it looks nice. But I have a lot of questions:
- The name is deployment docs but there are no changes in docs.
- Also the change with the admin, i dont really get it. Some comments on top or in the docs would help. My personal comment is that maybe we are complicating it a bit
Quick thinking out loud: do we really need this auth thing in the open source? MLFlow does not have any (no need to answer now).
gcharis
changed the title
Contributor
Author
|
@momegas you're right, we ended up doing more changes than that. The title is adapted. |
momegas
approved these changes
Jan 25, 2023
gcharis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.