Allow the user can change MaxRecentFiles#2373
Merged
MKleusberg merged 4 commits intosqlitebrowser:masterfrom Aug 17, 2020
lucydodo:dev
Merged
Allow the user can change MaxRecentFiles#2373MKleusberg merged 4 commits intosqlitebrowser:masterfrom lucydodo:dev
MKleusberg merged 4 commits intosqlitebrowser:masterfrom
lucydodo:dev
Conversation
lucydodo
changed the title
lucydodo
changed the title
Member
Author
|
May I ask for a review of my code? |
Member
|
@lucydodo Sure. I'll have a look later today 😄 |
Member
|
Thanks, @lucydodo! Looks good 👍 |
Member
Author
|
Thanks to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently made a pull request(#2347) to move the recent file list to a sub-menu and
received a suggestion to change the value of MaxRecentFiles during the review process.
Accordingly, I modified the code to allow the user to change the value of MaxRecentFiles.
In addition, I re-added the separator that was lost according to the existing patch.
Thank you.
Test Environment