Resolves #1163 Add function that supports query index dynamically#1166
Resolves #1163 Add function that supports query index dynamically#1166yaojiejia wants to merge 1 commit intosqlancer:mainfrom
Conversation
Remove hard-coded index
|
Hmm strange! I ran all the tests locally and they seem to be fine, will investigate further |
|
It seems like this triggered a bug in DuckDB. You could try to find a reduced version of the bug-inducing test case, see whether it still reproduces on the latest DuckDB version, and then report it to the developers. |
|
We will also need to add the indexes to the internal schema representation. See |
|
There is another PR that already addresses this: #1171 Did you already continue on this PR? Otherwise, I'd be inclined to focus on reviewing and merging the other PR, as it is more comprehensive despite you being first. What's your thought on this? |
Yeah I was trying to find out the root cause and trying to add the indexes to internal schema, but in the mean time I think you should look at the other PR and I will try to figure out what's going on in my end. Thanks!! |
2 participants
If I understand correctly, I just need to remove hard-coded index and use
globalState.getSchema().getFreeIndexName()insteadTests ran:
mvn package -DskipTestsmvn formatter:formatmvn verify -DskipTests=truemvn -Dtest=TestDuckDBTLP testmvn -Dtest=TestDuckDBNoREC testI don't think duckdb supports b-tree and hash index for the index type therefore I didn't include them in here