refactor: rename notFound method in MySQLDQEOracle.java

luliqwerty · luliqwerty · commit d76843182e20 · 2025-09-02T16:05:57.000+08:00
diff --git a/src/sqlancer/mysql/oracle/MySQLDQEOracle.java b/src/sqlancer/mysql/oracle/MySQLDQEOracle.java
@@ -204,7 +204,7 @@ public String compareSelectAndUpdate(SQLQueryResult selectResult, SQLQueryResult
             List<SQLQueryError> selectErrors = new ArrayList<>(selectResult.getQueryErrors());
             for (int i = 0; i < updateResult.getQueryErrors().size(); i++) {
                 SQLQueryError updateError = updateResult.getQueryErrors().get(i);
-                if (notFound(selectErrors, updateError)) {
+                if (!isFound(selectErrors, updateError)) {
                     return "SELECT has different errors from UPDATE.";
                 }
             }
@@ -231,7 +231,7 @@ public String compareSelectAndUpdate(SQLQueryResult selectResult, SQLQueryResult
      *
      * @return is targetError found in selectQueryErrors
      */
-    private static boolean notFound(List<SQLQueryError> selectErrors, SQLQueryError targetError) {
+    private static boolean isFound(List<SQLQueryError> selectErrors, SQLQueryError targetError) {
         boolean found = false;
         for (int i = 0; i < selectErrors.size(); i++) {
             SQLQueryError selectError = selectErrors.get(i);
@@ -241,7 +241,7 @@ private static boolean notFound(List<SQLQueryError> selectErrors, SQLQueryError
                 break;
             }
         }
-        return !found;
+        return found;
     }
 
     public String compareSelectAndDelete(SQLQueryResult selectResult, SQLQueryResult deleteResult) {
@@ -266,7 +266,7 @@ public String compareSelectAndDelete(SQLQueryResult selectResult, SQLQueryResult
             List<SQLQueryError> selectErrors = new ArrayList<>(selectResult.getQueryErrors());
             for (int i = 0; i < deleteResult.getQueryErrors().size(); i++) {
                 SQLQueryError deleteError = deleteResult.getQueryErrors().get(i);
-                if (notFound(selectErrors, deleteError)) {
+                if (!isFound(selectErrors, deleteError)) {
                     return "SELECT has different errors from DELETE.";
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ public String compareSelectAndUpdate(SQLQueryResult selectResult, SQLQueryResult`
`204`	`204`	`List<SQLQueryError> selectErrors = new ArrayList<>(selectResult.getQueryErrors());`
`205`	`205`	`for (int i = 0; i < updateResult.getQueryErrors().size(); i++) {`
`206`	`206`	`SQLQueryError updateError = updateResult.getQueryErrors().get(i);`
`207`		`- if (notFound(selectErrors, updateError)) {`
	`207`	`+ if (!isFound(selectErrors, updateError)) {`
`208`	`208`	`return "SELECT has different errors from UPDATE.";`
`209`	`209`	`}`
`210`	`210`	`}`
`@@ -231,7 +231,7 @@ public String compareSelectAndUpdate(SQLQueryResult selectResult, SQLQueryResult`
`231`	`231`	`*`
`232`	`232`	`* @return is targetError found in selectQueryErrors`
`233`	`233`	`*/`
`234`		`- private static boolean notFound(List<SQLQueryError> selectErrors, SQLQueryError targetError) {`
	`234`	`+ private static boolean isFound(List<SQLQueryError> selectErrors, SQLQueryError targetError) {`
`235`	`235`	`boolean found = false;`
`236`	`236`	`for (int i = 0; i < selectErrors.size(); i++) {`
`237`	`237`	`SQLQueryError selectError = selectErrors.get(i);`
`@@ -241,7 +241,7 @@ private static boolean notFound(List<SQLQueryError> selectErrors, SQLQueryError`
`241`	`241`	`break;`
`242`	`242`	`}`
`243`	`243`	`}`
`244`		`- return !found;`
	`244`	`+ return found;`
`245`	`245`	`}`
`246`	`246`
`247`	`247`	`public String compareSelectAndDelete(SQLQueryResult selectResult, SQLQueryResult deleteResult) {`
`@@ -266,7 +266,7 @@ public String compareSelectAndDelete(SQLQueryResult selectResult, SQLQueryResult`
`266`	`266`	`List<SQLQueryError> selectErrors = new ArrayList<>(selectResult.getQueryErrors());`
`267`	`267`	`for (int i = 0; i < deleteResult.getQueryErrors().size(); i++) {`
`268`	`268`	`SQLQueryError deleteError = deleteResult.getQueryErrors().get(i);`
`269`		`- if (notFound(selectErrors, deleteError)) {`
	`269`	`+ if (!isFound(selectErrors, deleteError)) {`
`270`	`270`	`return "SELECT has different errors from DELETE.";`
`271`	`271`	`}`
`272`	`272`	`}`