fix: broken grammar of LIKELIHOOD (#650)

bajinsheng · web-flow · commit ca70c6a9f934 · 2022-12-17T10:00:14.000Z
diff --git a/src/sqlancer/sqlite3/SQLite3Errors.java b/src/sqlancer/sqlite3/SQLite3Errors.java
@@ -21,7 +21,6 @@ public static void addExpectedExpressionErrors(ExpectedErrors errors) {
         errors.add("FTS expression tree is too large");
         errors.add("String or BLOB exceeds size limit");
         errors.add("[SQLITE_ERROR] SQL error or missing database (integer overflow)");
-        errors.add("second argument to likelihood() must be a constant between 0.0 and 1.0");
         errors.add("ORDER BY term out of range");
         errors.add("GROUP BY term out of range");
         errors.add("not authorized"); // load_extension
diff --git a/src/sqlancer/sqlite3/gen/SQLite3ExpressionGenerator.java b/src/sqlancer/sqlite3/gen/SQLite3ExpressionGenerator.java
@@ -547,6 +547,12 @@ private SQLite3Expression getFunction(SQLite3GlobalState globalState, int depth)
                 nrArgs += Randomly.smallNumber();
             }
             List<SQLite3Expression> expressions = randomFunction.generateArguments(nrArgs, depth + 1, this);
+            // The second argument of LIKELIHOOD must be a float number within 0.0 -1.0
+            if (randomFunction == AnyFunction.LIKELIHOOD) {
+                SQLite3Expression lastArg = SQLite3Constant.createRealConstant(Randomly.getPercentage());
+                expressions.remove(expressions.size() - 1);
+                expressions.add(lastArg);
+            }
             return new SQLite3Expression.Function(randomFunction.toString(),
                     expressions.toArray(new SQLite3Expression[0]));
         }
@@ -604,6 +610,11 @@ private SQLite3Expression getComputableFunction(int depth) {
                 args[i] = new SQLite3Distinct(args[i]);
             }
         }
+        // The second argument of LIKELIHOOD must be a float number within 0.0 -1.0
+        if (func == ComputableFunction.LIKELIHOOD) {
+            SQLite3Expression lastArg = SQLite3Constant.createRealConstant(Randomly.getPercentage());
+            args[args.length - 1] = lastArg;
+        }
         return new SQLite3Function(func, args);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -547,6 +547,12 @@ private SQLite3Expression getFunction(SQLite3GlobalState globalState, int depth)`
`547`	`547`	`nrArgs += Randomly.smallNumber();`
`548`	`548`	`}`
`549`	`549`	`List<SQLite3Expression> expressions = randomFunction.generateArguments(nrArgs, depth + 1, this);`
	`550`	`+ // The second argument of LIKELIHOOD must be a float number within 0.0 -1.0`
	`551`	`+ if (randomFunction == AnyFunction.LIKELIHOOD) {`
	`552`	`+ SQLite3Expression lastArg = SQLite3Constant.createRealConstant(Randomly.getPercentage());`
	`553`	`+ expressions.remove(expressions.size() - 1);`
	`554`	`+ expressions.add(lastArg);`
	`555`	`+ }`
`550`	`556`	`return new SQLite3Expression.Function(randomFunction.toString(),`
`551`	`557`	`expressions.toArray(new SQLite3Expression[0]));`
`552`	`558`	`}`
`@@ -604,6 +610,11 @@ private SQLite3Expression getComputableFunction(int depth) {`
`604`	`610`	`args[i] = new SQLite3Distinct(args[i]);`
`605`	`611`	`}`
`606`	`612`	`}`
	`613`	`+ // The second argument of LIKELIHOOD must be a float number within 0.0 -1.0`
	`614`	`+ if (func == ComputableFunction.LIKELIHOOD) {`
	`615`	`+ SQLite3Expression lastArg = SQLite3Constant.createRealConstant(Randomly.getPercentage());`
	`616`	`+ args[args.length - 1] = lastArg;`
	`617`	`+ }`
`607`	`618`	`return new SQLite3Function(func, args);`
`608`	`619`	`}`
`609`	`620`