Hf yaml cleanup#1800
Closed
anautsch wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
|
If this is too odd, we might also drop that branch on the speechbrain repo & create a new branch for this purpose that does not start from a speechbrain/develop copy (and retire this branch). |
Collaborator
Author
|
Nvmd - closing here. I created this orphan branch instead: https://github.com/speechbrain/speechbrain/tree/hf-interface-testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not supposed to go anywhere near the
developbranch.Purpose: tracking HF yaml/interface specifications & their testing.
When I created this branch, I simply checked out from develop - that was a bit too much. All that is really needed here from the develop branch are the linters.
I hope making a PR here isn't overkill, it's just so there's awareness of what's going on & some participation in how this branch can be shaped for testing automation when refactorings touch upon HF repos (such as wav2vec2 fixes & refactoring SB's transformers interface).