Conversation
0xnmn
added
the
backport 5.6.x
rrhyne
left a comment
rrhyne
left a comment
There was a problem hiding this comment.
Love it. Thanks for jumping in and getting this done!
There was a problem hiding this comment.
As the buttons implemented in Cody does not satisfy the design requirements and it will take longer to design them correctly, then making code changes in Cody, release Cody Web, and then finally update SG. I have been told to override the styles for buttons in SG for the patch release. And the team (me or someone else) will be follow up fixing Cody in next couple of days.
|
Pulled it down and took a peek. The only thing obvious I noticed was that the
|
updated. |
camdencheek
force-pushed
the
naman/cody-web-css-fixes
branch
from
c4e82e1 to
ff6a2db
Compare
closes: https://linear.app/sourcegraph/issue/SRCH-866/improve-cody-web-theming-for-consistency-with-rest-of-product This PR updates the Cody Web CSS based on the changes requested by @rrhyne. Few buttons implemented in Cody doesn't satisfy the design requirements and do not use the css variable so we couldn't update them easily but rather had to override the styles. ## Test plan Before:  After:  ## Changelog - Make Cody Web styles more accessible. (cherry picked from commit 2dd38b3)
closes: https://linear.app/sourcegraph/issue/SRCH-866/improve-cody-web-theming-for-consistency-with-rest-of-product This PR updates the Cody Web CSS based on the changes requested by @rrhyne. Few buttons implemented in Cody doesn't satisfy the design requirements and do not use the css variable so we couldn't update them easily but rather had to override the styles. ## Test plan Before:  After:  ## Changelog - Make Cody Web styles more accessible. <br> Backport 2dd38b3 from #64370 Co-authored-by: Naman Kumar <[email protected]>
3 participants
closes: https://linear.app/sourcegraph/issue/SRCH-866/improve-cody-web-theming-for-consistency-with-rest-of-product
This PR updates the Cody Web CSS based on the changes requested by @rrhyne.
Few buttons implemented in Cody doesn't satisfy the design requirements and do not use the css variable so we couldn't update them easily but rather had to override the styles.
Test plan
Before:
After:
Changelog