This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(cody): detect symbol names in query#62976
Merged
jtibshirani merged 6 commits intomainfrom May 30, 2024
Merged
Conversation
github-actions
bot
added
team/product-platform
team/search-platform
Contributor
Author
|
golden queries evals Before After CodeSearchNet evals: results unchanged |
keegancsmith
approved these changes
May 30, 2024
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
very nice.
One general question based on me not fully understanding stuff. Do we rely at all at NumContextLines to ensure we give enough context in the chunks? If so, do our symbol results respect that?
Contributor
Author
We do not rely on |
jtibshirani
changed the title
jtibshirani
changed the title
jtibshirani
added a commit
that referenced
this pull request
Jul 11, 2024
This PR fixes an important bug in #62976, where we didn't properly map the symbol line match to the return type. Instead, we accidentally treated symbol matches like file matches and returned the start of the file. ## Test plan Add new unit test for symbol match conversion. Extensive manual testing.
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
This PR fixes an important bug in #62976, where we didn't properly map the symbol line match to the return type. Instead, we accidentally treated symbol matches like file matches and returned the start of the file. ## Test plan Add new unit test for symbol match conversion. Extensive manual testing. (cherry picked from commit 004eb0f)
jdpleiness
pushed a commit
that referenced
this pull request
Jul 11, 2024
This PR fixes an important bug in #62976, where we didn't properly map the symbol line match to the return type. Instead, we accidentally treated symbol matches like file matches and returned the start of the file. ## Test plan Add new unit test for symbol match conversion. Extensive manual testing. <br> Backport 004eb0f from #63773 Co-authored-by: Julie Tibshirani <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Cody context search to pull symbol names out of the query and
perform an additional symbol search. The symbol search results are deduplicated
with the code search results, so we always prefer the symbol definition over
another file match.
Benefits:
(unless it is quite ambiguous). This is a basic thing users would expect, and
improves our "Find symbol" evals.
always anchored on the line with the definition.
Addresses SPLF-88
Test plan
Adapted unit tests. Tested locally.
Changelog
We've made various fixes and improvements to Enterprise Chat context (backed by Zoekt):