Skip to content

fix(chore): fixing sonar smells #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shubhamp-sf merged 1 commit into from
Apr 19, 2023
Merged

fix(chore): fixing sonar smells #120

shubhamp-sf merged 1 commit into from
Apr 19, 2023

Conversation

@arpit1503khanna
Copy link
Contributor

@arpit1503khanna arpit1503khanna commented Mar 22, 2023

Description

resolving sonar smells to improve quality gate

Fixes # (GH-110)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@arpit1503khanna
fix(chore): fixing sonar smells
8c4bfd6 
resolving sonar smells to improve quality gate

GH-110
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

yeshamavani
yeshamavani reviewed Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@yeshamavani yeshamavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only this change??

@arpit1503khanna
Copy link
Contributor Author

arpit1503khanna commented Apr 6, 2023

only this change??

yes

@shubhamp-sf shubhamp-sf merged commit 9e904b5 into master Apr 19, 2023
@shubhamp-sf shubhamp-sf deleted the GH-110 branch April 19, 2023 10:39
@sfdevops
Copy link
Contributor

sfdevops commented Apr 24, 2023

🎉 This PR is included in version 6.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yeshamavani yeshamavani yeshamavani left review comments

+1 more reviewer

@shubhamp-sf shubhamp-sf shubhamp-sf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arpit1503khanna @sfdevops @yeshamavani @shubhamp-sf