fix: Better error message when assigning to a value defined outside TGSL#1981
Merged
aleksanderkatan merged 11 commits intomainfrom Jan 14, 2026
Merged
fix: Better error message when assigning to a value defined outside TGSL#1981aleksanderkatan merged 11 commits intomainfrom
aleksanderkatan merged 11 commits intomainfrom
Conversation
|
pkg.pr.new packages benchmark commit |
Collaborator
|
I am not sure if this is proper way to detect 'assignment to variables defined outside TGSL'. We are adding support for 'for ... of ...' loop, so tinyest will change. Maybe you'll find a better place for that in tinyest parsers? EDIT: Nevermind, too much work for 1 error. LGTM |
cieplypolar
approved these changes
Dec 18, 2025
## 📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (323 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
iwoplaza
approved these changes
Jan 14, 2026
reczkok
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wgslGenerator.tsAfter this, the
lhsExpressionalready is a constant snippet, so I decided to just update the error message for assigning to a constant.Case 1:
as was before, an error
Identifier a not foundis thrown.Case 2:
Now the error message is
'${lhsStr} = ${rhsStr}' is invalid, because ${lhsStr} is a constant. This error may also occur when assigning to a value defined outside of a TypeGPU function's scope.